From owner-freebsd-net@FreeBSD.ORG  Thu Sep 22 01:18:27 2005
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@freebsd.org
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 215B916A41F
	for <freebsd-net@freebsd.org>; Thu, 22 Sep 2005 01:18:27 +0000 (GMT)
	(envelope-from demizu@dd.iij4u.or.jp)
Received: from r-dd.iij4u.or.jp (r-dd.iij4u.or.jp [210.130.0.70])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9CC3743D45
	for <freebsd-net@freebsd.org>; Thu, 22 Sep 2005 01:18:26 +0000 (GMT)
	(envelope-from demizu@dd.iij4u.or.jp)
Received: from localhost (h229.p049.iij4u.or.jp [210.130.49.229])
	by r-dd.iij4u.or.jp (4U-MR/r-dd) id j8M1IMwT001064;
	Thu, 22 Sep 2005 10:18:23 +0900 (JST)
Date: Thu, 22 Sep 2005 10:18:09 +0900 (JST)
Message-Id: <20050922.101809.45174516.Noritoshi@Demizu.ORG>
From: Noritoshi Demizu <demizu@dd.iij4u.or.jp>
To: freebsd-net@freebsd.org
In-Reply-To: <dgs53j$348$1@sea.gmane.org>
References: <20050921.161113.59648691.Noritoshi@Demizu.ORG>
	<20050921.184114.115904070.Noritoshi@Demizu.ORG>
	<dgs53j$348$1@sea.gmane.org>
X-Mailer: Mew version 4.1 on Emacs 21 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: Re: rfc2385 (tcp md5 checksums) in -current broken?
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Sep 2005 01:18:27 -0000

> > --- print-tcp.c-ORG   Thu Apr 21 15:36:05 2005
> > +++ print-tcp.c       Wed Sep 21 18:43:51 2005
> > @@ -799,7 +799,7 @@
> >  MD5_Update(&ctx, tcpmd5secret, strlen(tcpmd5secret));
> >  MD5_Final(sig, &ctx);
> >  
> > -     if (memcmp(rcvsig, sig, 16))
> > +     if (memcmp(rcvsig, sig, TCP_SIGLEN) == 0)
> >  return (SIGNATURE_VALID);
> >  else
> >  return (SIGNATURE_INVALID);
>
> The original code there certainly looks wrong!  After patching, FreeBSD's
> checksum returns valid.  I'll have to see what's up with the originating
> checksum.  Many Thanks!

Thanks.  I submitted this problem to the bug tracker of the tcpdump
project at http://sourceforge.net/projects/tcpdump/ .
The request ID is 1298259.

Regards,
Noritoshi Demizu