From owner-svn-src-projects@FreeBSD.ORG Mon Sep 7 20:33:52 2009 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B70921065679 for ; Mon, 7 Sep 2009 20:33:52 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from adsum.doit.wisc.edu (adsum.doit.wisc.edu [144.92.197.210]) by mx1.freebsd.org (Postfix) with ESMTP id 8AEC18FC0C for ; Mon, 7 Sep 2009 20:33:52 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=ISO-8859-1; format=flowed Received: from avs-daemon.smtpauth1.wiscmail.wisc.edu by smtpauth1.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7.0-5.01 32bit (built Feb 19 2009)) id <0KPM00A0090FZR00@smtpauth1.wiscmail.wisc.edu>; Mon, 07 Sep 2009 14:33:51 -0500 (CDT) Received: from comporellon.tachypleus.net ([unknown] [76.210.73.164]) by smtpauth1.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7.0-5.01 32bit (built Feb 19 2009)) with ESMTPSA id <0KPM00A8P90EBU00@smtpauth1.wiscmail.wisc.edu>; Mon, 07 Sep 2009 14:33:51 -0500 (CDT) Date: Mon, 07 Sep 2009 14:33:49 -0500 From: Nathan Whitehorn In-reply-to: To: Rafal Jaworowski Message-id: <4AA5601D.9040004@freebsd.org> X-Spam-Report: AuthenticatedSender=yes, SenderIP=76.210.73.164 X-Spam-PmxInfo: Server=avs-11, Version=5.5.5.374460, Antispam-Engine: 2.7.1.369594, Antispam-Data: 2009.9.7.192417, SenderIP=76.210.73.164 References: <200909071901.n87J1Yn7023803@svn.freebsd.org> User-Agent: Thunderbird 2.0.0.23 (X11/20090905) Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r196945 - projects/ppc64/sys/boot/common X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Sep 2009 20:33:52 -0000 Rafal Jaworowski wrote: > > On 2009-09-07, at 21:01, Nathan Whitehorn wrote: > >> Author: nwhitehorn >> Date: Mon Sep 7 19:01:34 2009 >> New Revision: 196945 >> URL: http://svn.freebsd.org/changeset/base/196945 >> >> Log: >> r60506 broke netbooting on PowerPC/OFW completely. We need a way of >> reverting this in a way that doesn't break Book-E. >> >> Modified: >> projects/ppc64/sys/boot/common/dev_net.c >> >> Modified: projects/ppc64/sys/boot/common/dev_net.c >> = >> = >> = >> = >> = >> = >> = >> = >> ====================================================================== >> --- projects/ppc64/sys/boot/common/dev_net.c Mon Sep 7 18:54:55 >> 2009 (r196944) >> +++ projects/ppc64/sys/boot/common/dev_net.c Mon Sep 7 19:01:34 >> 2009 (r196945) >> @@ -145,7 +145,7 @@ net_open(struct open_file *f, ...) >> return (error); >> } >> } >> -#if defined(__sparc64__) >> +#if defined(__sparc64__) || defined(__powerpc__) >> netdev_opens++; >> #endif >> } > > In general it's not a Book-E thing at all. It's clearly a bug not to > update the open counter (with the above change the loader will not > reach netif_close(), which is bad); I know some firmware versions have > had problems here, that lead to unresponsiveness or so, but it > shouldn't really depend on powerpc/sparc64 define: it's rather a > broken firmware/platform thing and should be handled as a platform > workaround (build option?), not something arch-related. > > Rafal > True. Basically, we should never try to reopen the net device on Open Firmware platforms. Maybe a new define so that the common loader code can check for OF? This firmware bug is *very* prevalent on Apple hardware. -Nathan