From owner-freebsd-current@FreeBSD.ORG Tue Dec 13 17:00:22 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A56AC16A426; Tue, 13 Dec 2005 17:00:22 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5B40E43D5C; Tue, 13 Dec 2005 17:00:16 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id jBDH0F5r060210; Tue, 13 Dec 2005 09:00:15 -0800 (PST) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id jBDH0FYb060209; Tue, 13 Dec 2005 09:00:15 -0800 (PST) (envelope-from obrien) Date: Tue, 13 Dec 2005 09:00:15 -0800 From: "David O'Brien" To: John Baldwin Message-ID: <20051213170015.GA60145@dragon.NUXI.org> Mail-Followup-To: freebsd-current@freebsd.org, John Baldwin , Gleb Smirnoff , imp@freebsd.org References: <20051211181324.G71610@ury.york.ac.uk> <1134481135.15730.76.camel@buffy.york.ac.uk> <1134485368.15730.95.camel@buffy.york.ac.uk> <200512131101.44375.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200512131101.44375.jhb@freebsd.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.11 Cc: freebsd-current@freebsd.org, imp@freebsd.org, Gleb Smirnoff Subject: Re: puc fails to attach serial ports X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: freebsd-current@freebsd.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Dec 2005 17:00:22 -0000 On Tue, Dec 13, 2005 at 11:01:42AM -0500, John Baldwin wrote: > Because sio(4) only includes sio_puc.c in the kernel if you have 'puc' in your > kernel config, and the puc kernel module only includes the puc files, it > doesn't include sio_puc.c and ppc_puc.c. uart has the same issue as well. > Looking at the three attachments, there's no reason for them to be dependent > on puc, they don't actually call any symbols in the puc(4) kernel module > itself, so they can be compiled into kernels w/o puc without causing any > harm. Then loading puc as a module would work. Here's a patch: Isn't there another way? It just seems wrong to include *_puc bits in the kernel if you don't have 'puc' in your kernel. There are some working on trimming down the kernel for embedded purposes and this patch seems counter to that effort. -- -- David (obrien@FreeBSD.org) Q: Because it reverses the logical flow of conversation. A: Why is top-posting (putting a reply at the top of the message) frowned upon?