From owner-freebsd-gnome Tue May 7 10:42:17 2002 Delivered-To: freebsd-gnome@freebsd.org Received: from gyros.marcuscom.com (dhcp-64-102-60-52.cisco.com [64.102.60.52]) by hub.freebsd.org (Postfix) with ESMTP id 20D4037B400 for ; Tue, 7 May 2002 10:42:11 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by gyros.marcuscom.com (8.12.3/8.12.3) with ESMTP id g47Hg19U018339; Tue, 7 May 2002 13:42:01 -0400 (EDT) (envelope-from marcus@marcuscom.com) Subject: Re: ports/37785 From: Joe Marcus Clarke To: Larry Rosenman Cc: gnome@FreeBSD.ORG In-Reply-To: <1020787193.438.20.camel@lerlaptop> References: <1020784927.438.16.camel@lerlaptop> <1020786937.44643.14.camel@shumai.marcuscom.com> <1020787193.438.20.camel@lerlaptop> Content-Type: multipart/mixed; boundary="=-RZPhUf2V4K/pn016Ht/G" X-Mailer: Ximian Evolution 1.0.3 Date: 07 May 2002 13:42:01 -0400 Message-Id: <1020793321.416.5.camel@gyros.marcuscom.com> Mime-Version: 1.0 Sender: owner-freebsd-gnome@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --=-RZPhUf2V4K/pn016Ht/G Content-Type: text/plain Content-Transfer-Encoding: 7bit On Tue, 2002-05-07 at 11:59, Larry Rosenman wrote: > On Tue, 2002-05-07 at 10:55, Joe Marcus Clarke wrote: > > On Tue, 2002-05-07 at 12:22, Larry Rosenman wrote: > > > Can someone look at this PR? > > > > I took a brief look at it yesterday. It looks like more of a glimmer > > problem that a "FreeBSD port of glimmer" problem. However, I'll take a > > more thorough look at it today. > > > I dropped a backtrace in it today. I did try to get a hold of the > author, but the mail just hung in my queue. See if this patch fixes the problem for you. Joe > > LER > > Joe > > > > > > > > I'd love to use glimmer, but it crashes on my source file (it's in the > > > PR). If you need more info, let me know.... > > > > > > Thanks, > > > LER > > > -- > > > Larry Rosenman http://www.lerctr.org/~ler > > > Phone: +1 972-414-9812 E-Mail: ler@lerctr.org > > > US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749 > > > > > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > > > with "unsubscribe freebsd-gnome" in the body of the message > > > > > > -- > Larry Rosenman http://www.lerctr.org/~ler > Phone: +1 972-414-9812 E-Mail: ler@lerctr.org > US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749 > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-gnome" in the body of the message > -- PGP Key: http://www.marcuscom.com/pgp.asc --=-RZPhUf2V4K/pn016Ht/G Content-Disposition: attachment; filename=patch-src_mdi-routines.c Content-Transfer-Encoding: quoted-printable Content-Type: text/x-c; name=patch-src_mdi-routines.c; charset=ISO8859-1 --- src/mdi-routines.c.orig Tue May 7 13:35:06 2002 +++ src/mdi-routines.c Tue May 7 13:40:16 2002 @@ -150,7 +150,7 @@ length =3D text->length; line =3D text->line_number + 1; lines =3D GTK_EXTEXT (cur_file->text)->line_count + 1; - if (pos >=3D 0 && pos <=3D text->length && text->length > 0) + if (pos >=3D 0 && pos < text->length && text->length > 0) cur_char =3D GTK_EXTEXT_INDEX (text, pos); else cur_char =3D 0; @@ -166,7 +166,10 @@ else gtk_widget_set_sensitive (search_menu_match, TRUE); =20 - cur_char =3D GTK_EXTEXT_INDEX (text, pos); + if (pos < text->length) + cur_char =3D GTK_EXTEXT_INDEX (text, pos); + else + cur_char =3D 0; if (cur_char < 1 || !strchr ("{[()]}", cur_char) || length < 1= ) gtk_widget_set_sensitive (search_menu_select, FALSE); else --=-RZPhUf2V4K/pn016Ht/G-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-gnome" in the body of the message