From owner-freebsd-current@FreeBSD.ORG  Tue Jan 14 16:08:19 2014
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 002E23FD;
 Tue, 14 Jan 2014 16:08:18 +0000 (UTC)
Received: from SMTP02.CITRIX.COM (smtp02.citrix.com [66.165.176.63])
 (using TLSv1 with cipher RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 525CF14B2;
 Tue, 14 Jan 2014 16:08:16 +0000 (UTC)
X-IronPort-AV: E=Sophos;i="4.95,658,1384300800"; d="scan'208";a="90613276"
Received: from accessns.citrite.net (HELO FTLPEX01CL03.citrite.net)
 ([10.9.154.239])
 by FTLPIPO02.CITRIX.COM with ESMTP; 14 Jan 2014 16:08:13 +0000
Received: from [IPv6:::1] (10.80.16.47) by smtprelay.citrix.com (10.13.107.80)
 with Microsoft SMTP Server id 14.2.342.4;
 Tue, 14 Jan 2014 11:08:12 -0500
Message-ID: <52D560EB.8040108@citrix.com>
Date: Tue, 14 Jan 2014 17:08:11 +0100
From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
 rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v10 14/20] xen: introduce xenpv bus and a dummy pvcpu
 device
References: <1389711582-66908-1-git-send-email-roger.pau@citrix.com>
 <1389711582-66908-15-git-send-email-roger.pau@citrix.com>
 <52D55AB4.4010504@linaro.org>
In-Reply-To: <52D55AB4.4010504@linaro.org>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-DLP: MIA2
Cc: xen-devel@lists.xen.org, julien.grall@citrix.com, freebsd-xen@freebsd.org,
 freebsd-current@freebsd.org, kib@freebsd.org, gibbs@freebsd.org
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jan 2014 16:08:19 -0000

On 14/01/14 16:41, Julien Grall wrote:
> On 01/14/2014 02:59 PM, Roger Pau Monne wrote:
>> +static int
>> +xenpv_attach(device_t dev)
>> +{
>> +	device_t child;
>> +
>> +	if (xen_hvm_domain()) {
>> +		device_t xenpci;
>> +		devclass_t dc;
>> +
>> +		/* Make sure xenpci has been attached */
>> +		dc = devclass_find("xenpci");
>> +		if (dc == NULL)
>> +			panic("unable to find xenpci devclass");
>> +
>> +		xenpci = devclass_get_device(dc, 0);
>> +		if (xenpci == NULL)
>> +			panic("unable to find xenpci device");
>> +
>> +		if (!device_is_attached(xenpci))
>> +			panic("trying to attach xenpv before xenpci");
>> +	}
> 
> Can you use the identify method to add the xenpci device?

I don't think so, xenpci is a pci device, it is detected and plugged by
the pci bus code.

> As I said earlier, I will reuse this code for ARM guest and this device
> is not used on this architecture.

You could move this chunk of code (the check for xenpci) to a static
inline function and make it a noop for ARM.