From owner-freebsd-current@FreeBSD.ORG Mon Jan 3 18:22:05 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CFF24106566C; Mon, 3 Jan 2011 18:22:05 +0000 (UTC) (envelope-from swell.k@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id DEE748FC0C; Mon, 3 Jan 2011 18:22:04 +0000 (UTC) Received: by wwf26 with SMTP id 26so13403675wwf.31 for ; Mon, 03 Jan 2011 10:22:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=jDvdq+rSNFZy4kTP48qt6eRE5GD7BODEPRNGQUt027s=; b=KyDI5WaBSi8uIehtTfzMBIx/VARym1zQTi+UqzE8pm4fyp2j6i5KUJlksozO4auyA3 19mAvIe/zGa8sgtwv4a2zc1GtF1+Vr0yUZfKFC3fR7TrbAsfZEbZCiG4yeOtXsFA/XgE nwZDK0YDfid2loGzQQY/RSOQipK3g903+LYnw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type:content-transfer-encoding; b=IG52ozu57Zd21y18hf0orVb0ng2C7xX2rfggddvzQ5mPGuXPFpVhbBnFHij1k7RB0u ASaaAX058fmxSHPoc0SMYSPMG+HOnqkKst3MY8RvuXgAc4UdFLoMw/ocHawrB2495fWw zIWnBv4syukqAaRV+/kK0Y8ZMd6gJGwZL3WaU= Received: by 10.216.1.149 with SMTP id 21mr24371039wed.10.1294078923940; Mon, 03 Jan 2011 10:22:03 -0800 (PST) Received: from localhost (server51262.uk2net.com [83.170.92.9]) by mx.google.com with ESMTPS id t5sm10024306wes.9.2011.01.03.10.22.01 (version=SSLv3 cipher=RC4-MD5); Mon, 03 Jan 2011 10:22:03 -0800 (PST) From: Anonymous To: Garrett Cooper References: <4D1B0E41.40405@gmail.com> <4D21CC35.5060803@gmx.de> <20110103141830.GC3140@deviant.kiev.zoral.com.ua> <47B52F19-AB6B-4116-9F5E-219B26519115@FreeBSD.org> Date: Mon, 03 Jan 2011 21:20:42 +0300 In-Reply-To: (Garrett Cooper's message of "Mon, 3 Jan 2011 09:55:30 -0800") Message-ID: <86vd256e85.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Belousov , Kostik, Matthias Andree , Edward Tomasz =?utf-8?Q?Napiera=C5=82a?= , "freebsd-current@freebsd.org" Subject: Re: No human readable message with g_vfs X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jan 2011 18:22:06 -0000 Garrett Cooper writes: > On Jan 3, 2011, at 8:33 AM, Edward Tomasz Napiera=C5=82a wrote: > >> Wiadomo=C5=9B=C4=87 napisana przez Kostik Belousov w dniu 2011-01-03, o = godz. 15:18: >>> On Mon, Jan 03, 2011 at 02:16:37PM +0100, Matthias Andree wrote: >>>> Am 03.01.2011 14:14, schrieb Ivan Voras: >>>>> On 12/29/10 11:32, David Demelier wrote: >>>>>> /var/log/messages.5.bz2:Nov 29 16:36:52 Abricot kernel: >>>>>> g_vfs_done():ufs/public[READ(offset=3D232718991360, length=3D131072)= ]error >>>>>> =3D 5 >>>>>>=20 >>>>>> I think for a lambda user these are absolutely not understandable. I >>>>>=20 >>>>> Would a better message be "WRITE error on da0, offset=3D34590720. >>>>> length=3D65536, errno=3D5"? >>>>=20 >>>> nah, strerror(errno) isn't that much of an effort >>> In kernel ? There is no strerror, and there is no great need to import = the >>> sys_errlist. >>=20 >> I had code that adds strerror() to the kernel in one of my old p4 branch= es. >> Error messages like the one above look much better this way, but I didn't >> have time to push it into the tree, and there is a risk of yet another i= 18n >> discussion. If someone is interested - let me know; I'll try to find it. > > Some thoughts: > - It's a pain to parse (before I just had to scan for an int -- now it's = a string?!?) > - It slows down printing (slow kernel -> dog slow system). > - Fills up logs quicker if a subsystem or piece of hardware is going > south and these messages slam syslog, which means I have to scan more > logs looking for useful data, the likelihood of messages being lost in > various buffers is higher, etc. > > Why not just provide a more standard sensical printout for the > messages and provide a secret decoder ring in userland or something Do you mean perror(1)? $ perror 5 Input/output error > for interested parties the don't know that error is an errno value (eg > my mom and dad because they're unix illiterate), or just copyout all > of the error data via an ioctl, print out the ioctl failures, and skip > the kernel level printing altogether?