From owner-svn-src-all@freebsd.org  Fri Aug 19 08:46:20 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 891ECBBE6BC;
 Fri, 19 Aug 2016 08:46:20 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (mail.turbocat.net
 [IPv6:2a01:4f8:d16:4514::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 53A1816D7;
 Fri, 19 Aug 2016 08:46:20 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from laptop015.home.selasky.org (unknown [62.141.129.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 463F91FE023;
 Fri, 19 Aug 2016 10:46:18 +0200 (CEST)
Subject: Re: svn commit: r304439 - head/sys/dev/usb/net
To: Pyun YongHyeon <yongari@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201608190050.u7J0oWkW043171@repo.freebsd.org>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <464a63e6-e96c-a2d5-099d-ae9059fa0877@selasky.org>
Date: Fri, 19 Aug 2016 10:50:47 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <201608190050.u7J0oWkW043171@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Aug 2016 08:46:20 -0000

On 08/19/16 02:50, Pyun YongHyeon wrote:
> Modified: head/sys/dev/usb/net/if_axgereg.h
> ==============================================================================
> --- head/sys/dev/usb/net/if_axgereg.h	Fri Aug 19 00:03:41 2016	(r304438)
> +++ head/sys/dev/usb/net/if_axgereg.h	Fri Aug 19 00:50:32 2016	(r304439)
> @@ -156,19 +156,20 @@ enum {
>  struct axge_frame_txhdr {
>  #if BYTE_ORDER == LITTLE_ENDIAN
>  	uint32_t		len;
> -#define	AXGE_TXLEN_MASK		0x0001FFFF
> -#define	AXGE_VLAN_INSERT	0x20000000
> -#define	AXGE_CSUM_DISABLE	0x80000000
>  	uint32_t		mss;
> -#define	AXGE_MSS_MASK		0x00003FFF
> -#define	AXGE_PADDING		0x80008000
> -#define	AXGE_VLAN_TAG_MASK	0xFFFF0000
>  #else
>  	uint32_t		mss;
>  	uint32_t		len;
>  #endif
>  } __packed;
>

Hi,

Is it correct to switch the order of mss and len variables for 
bit/little endian? Looks buggy to me.

--HPS