From owner-svn-src-all@freebsd.org Fri Aug 19 08:55:20 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 09C3EBBEBF7; Fri, 19 Aug 2016 08:55:20 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-pf0-x22e.google.com (mail-pf0-x22e.google.com [IPv6:2607:f8b0:400e:c00::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C88C01F6D; Fri, 19 Aug 2016 08:55:19 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by mail-pf0-x22e.google.com with SMTP id h186so7562989pfg.3; Fri, 19 Aug 2016 01:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YfXQLXhfCrtbL9hEECbiVbiA7IuOyD4cPqW29dbz7Ko=; b=Yu9dTA5Yv5SFV4LsRGAckowTahqB2IMPbod+UCsv8Pl0qNWzY1jJ6f8mvdtU+Dcan2 eBl1/D2yY8XFJMgx53Fb8er3yTav5sLAzfwWXDKnwin1Iq5bNHoZlyrWpshszGrKdxbt Vko8Q/Y9PyZqjFZjoAZfac/EOyP81/GC2FQQu/vRWIntGbfiWaLKqIWlvvTIalCgSJMx LXIGvg6HQvS4CvKzH8Q3lJtq5+gpbhZtRCZ0iber8VXmaFWJgmqmOz5/CgVatJ/vOd7k qwvqVRLj6+XF5ArS69JVfyLpA+AgTNH/8c7M1aHnJH/w/WixRigN4KlNhUCugdC29a8y fmeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=YfXQLXhfCrtbL9hEECbiVbiA7IuOyD4cPqW29dbz7Ko=; b=O7lnY1vCa5lEPZG/ZoaezAP3jlWMit4kpTtQXSOnqELJ3bjNYOwIWFmjb5dgdvMwiz zSDQDOSVaVBmDOcBi+qI1GpbuKd1OBZ6WPjaE8nCKyK+n6vkKcDfyYR0GCJlnY39ZC3N lQEXABZN/bPSbrg6n9H/6e7kCdgWwYyS3WGv2uJLex/2jH7KuP/j5PZljFPjRXJtt4u4 5YsC0TRd6FGZ10On3UyhEqUE8mRYUuajR1TN54k1p0OgscquOFQuglPD6G2A9xVQ9ZPT el7MRHU7R4Kysa9Ch3TBWsxLMn+W1yCkw/6DB0zesUBOVxrNCAAYmxxpLNtcEQ4xOSI4 bGeQ== X-Gm-Message-State: AEkoouutN/LHwyPp7MkndgVeprwsHPX1hUpKLeJ3FEtpGrKz58vJ+UjzrWpZ0ydf6m5fRQ== X-Received: by 10.98.11.86 with SMTP id t83mr12085175pfi.51.1471596919354; Fri, 19 Aug 2016 01:55:19 -0700 (PDT) Received: from localhost ([106.247.248.2]) by smtp.gmail.com with ESMTPSA id xv9sm9514248pab.36.2016.08.19.01.55.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Aug 2016 01:55:18 -0700 (PDT) From: YongHyeon PYUN X-Google-Original-From: "YongHyeon PYUN" Received: by localhost (sSMTP sendmail emulation); Fri, 19 Aug 2016 17:55:11 +0900 Date: Fri, 19 Aug 2016 17:55:11 +0900 To: Hans Petter Selasky Cc: Pyun YongHyeon , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r304439 - head/sys/dev/usb/net Message-ID: <20160819085511.GF1186@michelle.fasterthan.co.kr> Reply-To: pyunyh@gmail.com References: <201608190050.u7J0oWkW043171@repo.freebsd.org> <464a63e6-e96c-a2d5-099d-ae9059fa0877@selasky.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <464a63e6-e96c-a2d5-099d-ae9059fa0877@selasky.org> User-Agent: Mutt/1.4.2.3i X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2016 08:55:20 -0000 On Fri, Aug 19, 2016 at 10:50:47AM +0200, Hans Petter Selasky wrote: > On 08/19/16 02:50, Pyun YongHyeon wrote: > >Modified: head/sys/dev/usb/net/if_axgereg.h > >============================================================================== > >--- head/sys/dev/usb/net/if_axgereg.h Fri Aug 19 00:03:41 2016 (r304438) > >+++ head/sys/dev/usb/net/if_axgereg.h Fri Aug 19 00:50:32 2016 (r304439) > >@@ -156,19 +156,20 @@ enum { > > struct axge_frame_txhdr { > > #if BYTE_ORDER == LITTLE_ENDIAN > > uint32_t len; > >-#define AXGE_TXLEN_MASK 0x0001FFFF > >-#define AXGE_VLAN_INSERT 0x20000000 > >-#define AXGE_CSUM_DISABLE 0x80000000 > > uint32_t mss; > >-#define AXGE_MSS_MASK 0x00003FFF > >-#define AXGE_PADDING 0x80008000 > >-#define AXGE_VLAN_TAG_MASK 0xFFFF0000 > > #else > > uint32_t mss; > > uint32_t len; > > #endif > > } __packed; > > > > Hi, > > Is it correct to switch the order of mss and len variables for > bit/little endian? Looks buggy to me. > I think the order is right but it was not tested on big-endian systems.