From owner-svn-src-all@freebsd.org  Fri Aug 19 09:07:28 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E0590BBEFD8;
 Fri, 19 Aug 2016 09:07:28 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (mail.turbocat.net
 [IPv6:2a01:4f8:d16:4514::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id A9949164F;
 Fri, 19 Aug 2016 09:07:28 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from laptop015.home.selasky.org (unknown [62.141.129.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 037D01FE023;
 Fri, 19 Aug 2016 11:07:26 +0200 (CEST)
Subject: Re: svn commit: r304439 - head/sys/dev/usb/net
To: pyunyh@gmail.com
References: <201608190050.u7J0oWkW043171@repo.freebsd.org>
 <464a63e6-e96c-a2d5-099d-ae9059fa0877@selasky.org>
 <20160819085511.GF1186@michelle.fasterthan.co.kr>
Cc: Pyun YongHyeon <yongari@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <2e8143d4-eb32-693d-e5a4-49c380c100df@selasky.org>
Date: Fri, 19 Aug 2016 11:11:56 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <20160819085511.GF1186@michelle.fasterthan.co.kr>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Aug 2016 09:07:29 -0000

On 08/19/16 10:55, YongHyeon PYUN wrote:
> I think the order is right but it was not tested on big-endian
> systems.

Hi,

I'm pretty sure the ifdef is wrong, because you write the fields one at 
a time, using htole32():

                         txhdr.mss = 0;
                         txhdr.len = htole32(AXGE_TXBYTES(m->m_pkthdr.len));

Big endian machines don't re-order variables like this.

You should remove the #else part.

--HPS