From owner-cvs-all Mon Oct 29 0: 5:52 2001 Delivered-To: cvs-all@freebsd.org Received: from iguana.aciri.org (iguana.aciri.org [192.150.187.36]) by hub.freebsd.org (Postfix) with ESMTP id 326B137B406; Mon, 29 Oct 2001 00:05:46 -0800 (PST) Received: (from rizzo@localhost) by iguana.aciri.org (8.11.3/8.11.1) id f9T82Hr95971; Mon, 29 Oct 2001 00:02:17 -0800 (PST) (envelope-from rizzo) Date: Mon, 29 Oct 2001 00:02:16 -0800 From: Luigi Rizzo To: "Andrew R. Reiter" Cc: Josef Karthauser , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: ipfw.c -- (was: cvs commit: src/sys/netinet ip_fw.h) Message-ID: <20011029000216.A95875@iguana.aciri.org> References: <20011028215038.C94510@iguana.aciri.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.23i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Oct 29, 2001 at 01:05:44AM -0500, Andrew R. Reiter wrote: > On Sun, 28 Oct 2001, Luigi Rizzo wrote: > : > :i seem to remember something about variable scoping in the style(9) > :manpage, but i cannot find it anymore in FreeBSD 4.3. > > In 4.4-RELEASE, style.9 says: > > Parts of a for loop may be left empty. Don't put declarations inside > blocks unless the routine is unusually complicated. oh yes, that was it. Well, I think that in the above section of style(9), the only reasonable interpretation of "the routine" is "the function in which the block is contained"; otherwise, you should assume that you are not supposed to use local variables in small functions! > In ipfw.c, there are a number of areas in which it does not make sense, in > terms of style.9, to declare a variable as local to the point where it's > no longer at the head of a function. Ie: I think this is exactly the case where it makes a lot of sense to declare vars locally to the block: the start of the function is far away, there is a bunch of small conditionals where each of them needs to use some temporary variable and those variables are meant to be used only within the block. cheers luigi ----------------------------------+----------------------------------------- Luigi RIZZO, luigi@iet.unipi.it . ACIRI/ICSI (on leave from Univ. di Pisa) http://www.iet.unipi.it/~luigi/ . 1947 Center St, Berkeley CA 94704 Phone: (510) 666 2927 ----------------------------------+----------------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message