From owner-svn-ports-head@FreeBSD.ORG  Fri May 24 06:24:14 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 7568B7B2; Fri, 24 May 2013 06:24:14 +0000 (UTC)
Date: Fri, 24 May 2013 06:24:14 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Chris Rees <utisoft@gmail.com>
Subject: Re: svn commit: r318913 - in head/devel/libcfu: . files
Message-ID: <20130524062414.GA96324@FreeBSD.org>
References: <201305232205.r4NM5MSa002349@svn.freebsd.org>
 <20130524033728.GE48975@FreeBSD.org>
 <CADLo838BUMHeCv7v16QU41fWy3Yyia2DsK7jBfM42q8=A7ZV0w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CADLo838BUMHeCv7v16QU41fWy3Yyia2DsK7jBfM42q8=A7ZV0w@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: Chris Rees <crees@freebsd.org>, svn-ports-head@freebsd.org,
 svn-ports-all@freebsd.org, ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 24 May 2013 06:24:14 -0000

On Fri, May 24, 2013 at 07:08:56AM +0100, Chris Rees wrote:
> On 24 May 2013 04:37, "Alexey Dokuchaev" <danfe@freebsd.org> wrote:
> > On Thu, May 23, 2013 at 10:05:22PM +0000, Chris Rees wrote:
> > > New Revision: 318913
> > > URL: http://svnweb.freebsd.org/changeset/ports/318913
> > >
> > > Log:
> > >   New versions of clang complain about assigning variables to
> > >   themselves.
> > >
> > >   Let's just remove -Werror and ignore the warnings.
> >
> > Hmm, wouldn't it be better to fix these bugs (judging from commit log it
> > should not be too hard) and send the patch upstream?
> 
> They are just example files, doing silly things such as;
> 
> argc = argc;
> 
> Trouble is, removing these leads to "unused variable" warnings, so really
> it's better to ignore the warnings.

OK, I see.  But wouldn't casting to void help?

	(void)argc;

It could be even automated with simple sed(1) expression (REINPLACE_CMD) to
avoid big cumbersome patch...

./danfe