From owner-freebsd-virtualization@freebsd.org  Tue Mar  1 09:55:44 2016
Return-Path: <owner-freebsd-virtualization@freebsd.org>
Delivered-To: freebsd-virtualization@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CADECABDC1A
 for <freebsd-virtualization@mailman.ysv.freebsd.org>;
 Tue,  1 Mar 2016 09:55:44 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: from phabric-backend.rbsd.freebsd.org (unknown
 [IPv6:2607:fc50:2000:101::1bb:73])
 by mx1.freebsd.org (Postfix) with ESMTP id B8D101EC4
 for <freebsd-virtualization@freebsd.org>; Tue,  1 Mar 2016 09:55:44 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: by phabric-backend.rbsd.freebsd.org (Postfix, from userid 1346)
 id B11553322390; Tue,  1 Mar 2016 09:55:44 +0000 (UTC)
Date: Tue, 1 Mar 2016 09:55:44 +0000
To: freebsd-virtualization@freebsd.org
From: "iateaca (Teaca)" <phabric-noreply@FreeBSD.org>
Reply-to: D5473+333+79492675d52ac1ab@reviews.freebsd.org
Subject: [Differential] [Commented On] D5473: ATA/ATAPI6 device emulation in
 bhyve
Message-ID: <dbe23a329ee07449aa94524837bbbdea@localhost.localdomain>
X-Priority: 3
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
Thread-Topic: D5473: ATA/ATAPI6 device emulation in bhyve
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-upirdfykwaujxq3vuzqo>
X-Phabricator-To: <PHID-USER-2monqlbk24m6mwkbdamf>
X-Phabricator-To: <PHID-USER-fbdcs7ahjev7eqpeqr2a>
X-Phabricator-To: <PHID-USER-4nfkmwndyskujbxjzjxc>
X-Phabricator-To: <PHID-USER-tmsdq7z6rym2k7agm3fv>
X-Phabricator-Cc: <PHID-USER-6ps3unnxvniqcn5kdjn5>
Precedence: bulk
In-Reply-To: <differential-rev-PHID-DREV-2t5o3zrdohcj7mowtyki-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-2t5o3zrdohcj7mowtyki-req@FreeBSD.org>
Thread-Index: ZmQ1YjBmNDNhNWVhZDYwNjJmNTU3Y2FmMjRkIFbVZyA=
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-Mailman-Approved-At: Tue, 01 Mar 2016 12:10:51 +0000
X-BeenThere: freebsd-virtualization@freebsd.org
X-Mailman-Version: 2.1.20
List-Id: "Discussion of various virtualization techniques FreeBSD supports."
 <freebsd-virtualization.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-virtualization>, 
 <mailto:freebsd-virtualization-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-virtualization/>
List-Post: <mailto:freebsd-virtualization@freebsd.org>
List-Help: <mailto:freebsd-virtualization-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>, 
 <mailto:freebsd-virtualization-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Mar 2016 09:55:44 -0000

iateaca added a comment.


  In https://reviews.freebsd.org/D5473#117324, @mav wrote:
  
  > It was definitely significant amount of work, but I am not sure what motivation was behind it.  Why do we need it after already having much more featured AHCI-based ATA/ATAPI emulation? Are there any significant OS not supporting AHCI? There is significant amount of code duplication between implementations, plus this one obviously requires more work to be complete.
  
  
  The motivation is to run older versions of operating systems such as FreeBSD 4 which does not have AHCI drivers.
  What do you mean by code duplication ? I think only the ATAPI CDROM logic could be common but the current implementation from AHCI can not be used with the ATA data strcutures. If we want to achive this, I think a redesign of AHCI ATAPI is required too.

REVISION DETAIL
  https://reviews.freebsd.org/D5473

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: iateaca, grehan, neel, tychon, mav
Cc: freebsd-virtualization-list