From owner-svn-src-head@FreeBSD.ORG Tue Dec 27 16:28:00 2011 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 16543106566B; Tue, 27 Dec 2011 16:28:00 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) by mx1.freebsd.org (Postfix) with ESMTP id 8500F8FC17; Tue, 27 Dec 2011 16:27:59 +0000 (UTC) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.14.4/8.14.4/ALCHEMY.FRANKEN.DE) with ESMTP id pBRGRvHF073003; Tue, 27 Dec 2011 17:27:57 +0100 (CET) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.14.4/8.14.4/Submit) id pBRGRvDk073002; Tue, 27 Dec 2011 17:27:57 +0100 (CET) (envelope-from marius) Date: Tue, 27 Dec 2011 17:27:57 +0100 From: Marius Strobl To: Doug Barton Message-ID: <20111227162757.GW90831@alchemy.franken.de> References: <201112241216.pBOCGd1H012696@svn.freebsd.org> <4EF645D2.8080407@FreeBSD.org> <20111226102820.GT90831@alchemy.franken.de> <4EF8DC5B.9070404@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4EF8DC5B.9070404@FreeBSD.org> User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r228857 - in head/usr.bin: . csup X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Dec 2011 16:28:00 -0000 On Mon, Dec 26, 2011 at 12:43:07PM -0800, Doug Barton wrote: > On 12/26/2011 02:28, Marius Strobl wrote: > > On Sat, Dec 24, 2011 at 01:36:18PM -0800, Doug Barton wrote: > >> On 12/24/2011 04:16, Marius Strobl wrote: > >>> On FreeBSD just use the MD5 implementation of libmd rather than that of > >>> libcrypto so we don't need to relinquish csup when world is built without > >>> OpenSSL. > >> > >> Did you benchmark this at all? I agree that keeping csup available > >> absent openssl is a good goal, but csup is a prototypical "tool that > >> does the same thing many thousands of times" so even tiny regressions > >> could add up to a large cost in wall clock time. > > > > Well, in a real world test updating the same base on an amd64 machine > > connected to the Internet > > Adding a network connection to the test is almost certainly going to > obscure the results beyond utility. The appropriate way to test this > would be to create a binary out of the md5 routine in csup, and link it > alternately with libcrypto and libmd. Then for each version run it > against the src tree (or ports, either way) 10 times. Discard the first > and last, and then plot the results with ministat. marius@flak:/home/marius > ministat -w 76 libmd libcrypto x libmd + libcrypto +----------------------------------------------------------------------------+ | + | | + | |x x + | |xxx ++ | |xxx ++ +| ||A| |A_| | +----------------------------------------------------------------------------+ N Min Max Median Avg Stddev x 8 244.08 246.16 245.18 245.01375 0.78758106 + 8 302.36 307.12 302.92 303.26875 1.5784028 Difference at 95.0% confidence 58.255 +/- 1.33776 23.7762% +/- 0.545992% (Student's t, pooled s = 1.24732) Looks like the MD5 implementation of libcrypto is the counterpart of SCHED_ULE and only pays out on real big stuff. At least this result is consistent with the real world test of csup. Marius