From owner-cvs-src@FreeBSD.ORG Tue Mar 2 00:28:17 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E17C16A4CE; Tue, 2 Mar 2004 00:28:17 -0800 (PST) Received: from mail018.syd.optusnet.com.au (mail018.syd.optusnet.com.au [211.29.132.72]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6D95B43D1D; Tue, 2 Mar 2004 00:28:12 -0800 (PST) (envelope-from PeterJeremy@optushome.com.au) Received: from cirb503493.alcatel.com.au (c211-30-75-229.belrs2.nsw.optusnet.com.au [211.30.75.229]) i228S3509225; Tue, 2 Mar 2004 19:28:04 +1100 Received: from cirb503493.alcatel.com.au (localhost.alcatel.com.au [127.0.0.1])i228RwSU091984; Tue, 2 Mar 2004 19:28:03 +1100 (EST) (envelope-from jeremyp@cirb503493.alcatel.com.au) Received: (from jeremyp@localhost)i228Rws7091983; Tue, 2 Mar 2004 19:27:58 +1100 (EST) (envelope-from jeremyp) Date: Tue, 2 Mar 2004 19:27:58 +1100 From: Peter Jeremy To: Colin Percival Message-ID: <20040302082758.GF56509@cirb503493.alcatel.com.au> References: <200403011649.i21GncBT007285@repoman.freebsd.org> <6.0.1.1.1.20040301165122.03942a20@imap.sfu.ca> <20040301173329.GB7533@ip.net.ua> <6.0.1.1.1.20040301174718.0396fcc0@imap.sfu.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6.0.1.1.1.20040301174718.0396fcc0@imap.sfu.ca> User-Agent: Mutt/1.4.2i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/locale setlocale.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Mar 2004 08:28:17 -0000 On Mon, Mar 01, 2004 at 05:55:21PM +0000, Colin Percival wrote: > We really need to get some access checks put in place to stop things >like this from happening... Presumably these are just accidental events - a committer has missed the entry in MAINTAINERS or a "tree locked" notice. In most cases, they are probably just as embarrassing for the committer as they are annoying for other affected parties. In this case, what is needed is some sort of warning message "You are committing to a locked branch and haven't included an 'Approved by' line. Are you sure you want to continue?" It would seem fairly trivial to turn src/MAINTAINERS into a file that can be parsed by (eg) CVSROOT*/commit_prep.pl and generate a suitable warning. Obviously, this won't stop deliberate transgressions - but the Project already has various procedures to handle those. Peter