From owner-svn-ports-head@freebsd.org Sat Sep 12 14:52:17 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 196F7A02B6B; Sat, 12 Sep 2015 14:52:17 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E62461241; Sat, 12 Sep 2015 14:52:15 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from [192.168.0.23] (unknown [130.255.19.36]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id DC22043C22; Sat, 12 Sep 2015 09:52:07 -0500 (CDT) Subject: Re: svn commit: r396689 - in head/mail: cyrus-imapd23 cyrus-imapd24 cyrus-imapd25 To: Hajimu UMEMOTO , Mathieu Arnold References: <201509111758.t8BHwjA5064734@repo.freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Reply-To: marino@freebsd.org From: John Marino Message-ID: <55F43C0A.7050307@marino.st> Date: Sat, 12 Sep 2015 16:51:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Sep 2015 14:52:17 -0000 On 9/12/2015 4:46 PM, Hajimu UMEMOTO wrote: > Hi, > >>>>>> On Sat, 12 Sep 2015 12:52:39 +0200 >>>>>> Mathieu Arnold said: > > mat> | It seems your changes have many reasons. It is hard to inspect > mat> | whether it becomes equivalent to the one I intended. Could you back > mat> | all of your changes out, then separate every change reason and send > mat> | your proposed diffs to me. > > mat> With respect, no. The thing that you wanted, that is, the man pages > mat> definitions in the Makefie are back where they were. All the other changes > mat> are things the framework was already doing and that you were duplicating. > > Then, I'll back them out by myself, sigh. It is hard to inspect > whether it becomes equivalent to the one I intended. You could make > me be disappointed at your effort. > ume, I think this would be an example of bad citizenship. You have no reason to think Matt's commits are wrong. Unless you have some evidence they are, you should assume they are correct. That also gives you lots and lots of time to go through the changes at your pace. I really don't want to see good changes backed out for bad code, which is what it is being described as. Does poudriere pass QA checks or not? If it does, then the port is working as intended, right? John