From owner-freebsd-current Wed Apr 24 06:40:59 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id GAA15503 for current-outgoing; Wed, 24 Apr 1996 06:40:59 -0700 (PDT) Received: from robin.mcnc.org.mcnc.org (robin.mcnc.org [128.109.130.29]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id GAA15498 Wed, 24 Apr 1996 06:40:57 -0700 (PDT) Received: by robin.mcnc.org.mcnc.org (8.6.9/MCNC/8-10-92) id JAA14983; Wed, 24 Apr 1996 09:40:52 -0400 for Date: Wed, 24 Apr 1996 09:40:52 -0400 From: "Frank E. Terhaar-Yonkers" Message-Id: <199604241340.JAA14983@robin.mcnc.org.mcnc.org> To: current@freebsd.org Subject: minor syscons bogon Cc: freebsd-current@freebsd.org X-Face: ,fjtWiMPydUaSQl%8[eTg`u:^BXt&T)Sny(6w\*U"5D9H[Z$kG%Q/z;Z=NwrPiXf-aMF3R) Rsand$,]26-8>5@HD(A3A79gN|0%NHsdek4mT8E,>j+\w!~d2#nH;~NV!5a0"`5$Cj8d\or(Jy/JQ_ |uc;C[filmZ(~#lre*l:|O%d/PJFy`.5w8)sMZ-)QI3TaV"j'k Sender: owner-current@freebsd.org X-Loop: FreeBSD.org Precedence: bulk I posted recently that I was having trouble with console lockups while running X. This problem was a combination of "I'm a stupid" and a minor bug in syscons.c. I'd recompiled my kernel with MAXCONS set to to 4, to save a few bytes of memory and left xdm getty'd to ttyv4 - duh. Only, the bloody thing ran - for a while, until it had tiptoed thru enuf memory ... Would someone kindly commit this patch so others don't fall in the same hole? I believe pcvt has the same bug, but haven't looked at it. - Frank *** syscons.c.orig Thu Feb 8 04:25:44 1996 --- syscons.c Wed Apr 24 05:31:05 1996 *************** *** 305,311 **** if (!init_done) return(NULL); ! if (unit > MAXCONS || unit < 0) return(NULL); if (unit == MAXCONS) return CONSOLE_TTY; --- 305,311 ---- if (!init_done) return(NULL); ! if (unit >= MAXCONS || unit < 0) return(NULL); if (unit == MAXCONS) return CONSOLE_TTY; \\\\////\\\\////\\\\\////\\\\\////\\\\////\\\\////\\\\////\\\\////\\\\////\\\\ Frank Terhaar-Yonkers, Manager High Performance Computing and Communications Research MCNC PO Box 12889 3021 Cornwallis Road Research Triangle Park, North Carolina 27709-2889 fty@mcnc.org voice (919)248-1417 FAX (919)248-1455 http://www.mcnc.org/hpcc.html