From owner-freebsd-gnome Tue May 7 11:31:45 2002 Delivered-To: freebsd-gnome@freebsd.org Received: from lerlaptop.iadfw.net (lerlaptop.iadfw.net [206.66.13.21]) by hub.freebsd.org (Postfix) with ESMTP id BDCC937B404 for ; Tue, 7 May 2002 11:31:20 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by lerlaptop.iadfw.net (8.12.3/8.12.3) with ESMTP id g47IVI0D022761; Tue, 7 May 2002 13:31:18 -0500 (CDT) (envelope-from ler@lerctr.org) Subject: Re: ports/37785 From: Larry Rosenman To: Joe Marcus Clarke Cc: gnome@FreeBSD.ORG In-Reply-To: <1020795999.416.11.camel@gyros.marcuscom.com> References: <1020784927.438.16.camel@lerlaptop> <1020786937.44643.14.camel@shumai.marcuscom.com> <1020787193.438.20.camel@lerlaptop> <1020793321.416.5.camel@gyros.marcuscom.com> <1020793855.438.27.camel@lerlaptop> <1020795999.416.11.camel@gyros.marcuscom.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Mailer: Ximian Evolution 1.0.3 Date: 07 May 2002 13:31:18 -0500 Message-Id: <1020796278.438.32.camel@lerlaptop> Mime-Version: 1.0 Sender: owner-freebsd-gnome@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 2002-05-07 at 13:26, Joe Marcus Clarke wrote: > On Tue, 2002-05-07 at 13:50, Larry Rosenman wrote: > > On Tue, 2002-05-07 at 12:42, Joe Marcus Clarke wrote: > > > On Tue, 2002-05-07 at 11:59, Larry Rosenman wrote: > > > > On Tue, 2002-05-07 at 10:55, Joe Marcus Clarke wrote: > > > > > On Tue, 2002-05-07 at 12:22, Larry Rosenman wrote: > > > > > > Can someone look at this PR? > > > > > > > > > > I took a brief look at it yesterday. It looks like more of a glimmer > > > > > problem that a "FreeBSD port of glimmer" problem. However, I'll take a > > > > > more thorough look at it today. > > > > > > > > > I dropped a backtrace in it today. I did try to get a hold of the > > > > author, but the mail just hung in my queue. > > > > > > See if this patch fixes the problem for you. > > It does. Thanks! > > Can you get this patch to the author to see what they think. I'm not > really sure this is the right way to do this. I'll add this to our > ports tree, but I really think this should be fixed in the main glimmer > tree. When his ISP gets out from under a FR outage, and can accept mail again. THanks > > Joe > > > > > > > Joe > > > > > > > > > > > LER > > > > > Joe > > > > > > > > > > > > > > > > > I'd love to use glimmer, but it crashes on my source file (it's in the > > > > > > PR). If you need more info, let me know.... > > > > > > > > > > > > Thanks, > > > > > > LER > > > > > > -- > > > > > > Larry Rosenman http://www.lerctr.org/~ler > > > > > > Phone: +1 972-414-9812 E-Mail: ler@lerctr.org > > > > > > US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749 > > > > > > > > > > > > > > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > > > > > > with "unsubscribe freebsd-gnome" in the body of the message > > > > > > > > > > > > > > > -- > > > > Larry Rosenman http://www.lerctr.org/~ler > > > > Phone: +1 972-414-9812 E-Mail: ler@lerctr.org > > > > US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749 > > > > > > > > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > > > > with "unsubscribe freebsd-gnome" in the body of the message > > > > > > > -- > > > PGP Key: http://www.marcuscom.com/pgp.asc > > > ---- > > > > > > > > --- src/mdi-routines.c.orig Tue May 7 13:35:06 2002 > > > +++ src/mdi-routines.c Tue May 7 13:40:16 2002 > > > @@ -150,7 +150,7 @@ > > > length = text->length; > > > line = text->line_number + 1; > > > lines = GTK_EXTEXT (cur_file->text)->line_count + 1; > > > - if (pos >= 0 && pos <= text->length && text->length > 0) > > > + if (pos >= 0 && pos < text->length && text->length > 0) > > > cur_char = GTK_EXTEXT_INDEX (text, pos); > > > else > > > cur_char = 0; > > > @@ -166,7 +166,10 @@ > > > else > > > gtk_widget_set_sensitive (search_menu_match, TRUE); > > > > > > - cur_char = GTK_EXTEXT_INDEX (text, pos); > > > + if (pos < text->length) > > > + cur_char = GTK_EXTEXT_INDEX (text, pos); > > > + else > > > + cur_char = 0; > > > if (cur_char < 1 || !strchr ("{[()]}", cur_char) || length < 1) > > > gtk_widget_set_sensitive (search_menu_select, FALSE); > > > else > > -- > > Larry Rosenman http://www.lerctr.org/~ler > > Phone: +1 972-414-9812 E-Mail: ler@lerctr.org > > US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749 > > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > > with "unsubscribe freebsd-gnome" in the body of the message > > > -- > PGP Key: http://www.marcuscom.com/pgp.asc -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 972-414-9812 E-Mail: ler@lerctr.org US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-gnome" in the body of the message