From owner-cvs-all@FreeBSD.ORG  Sun Sep 28 14:09:54 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 518C316A4B3; Sun, 28 Sep 2003 14:09:54 -0700 (PDT)
Received: from mail.chesapeake.net (chesapeake.net [208.142.252.6])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id CDC5643FF7; Sun, 28 Sep 2003 14:09:52 -0700 (PDT)
	(envelope-from jroberson@chesapeake.net)
Received: from localhost (jroberson@localhost)
	by mail.chesapeake.net (8.11.6/8.11.6) with ESMTP id h8SL9qe44483;
	Sun, 28 Sep 2003 17:09:52 -0400 (EDT)
	(envelope-from jroberson@chesapeake.net)
Date: Sun, 28 Sep 2003 17:09:52 -0400 (EDT)
From: Jeff Roberson <jroberson@chesapeake.net>
To: Poul-Henning Kamp <phk@FreeBSD.org>
In-Reply-To: <200309282048.h8SKmD5d088918@repoman.freebsd.org>
Message-ID: <20030928170907.A99666-100000@mail.chesapeake.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/net if.c src/sys/dev/nmdm nmdm.c        
 src/sys/dev/usb ugen.c uhid.c ulpt.c ums.c uscanner.c        
 src/sys/netgraph/bluetooth/dr
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Sep 2003 21:09:54 -0000

On Sun, 28 Sep 2003, Poul-Henning Kamp wrote:

> phk         2003/09/28 13:48:13 PDT
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/net              if.c
>     sys/dev/nmdm         nmdm.c
>     sys/dev/usb          ugen.c uhid.c ulpt.c ums.c uscanner.c
>     sys/netgraph/bluetooth/drivers/ubt ng_ubt.c
>     sys/netgraph/bluetooth/drivers/ubtbcmfw ubtbcmfw.c
>   Log:
>   I don't know from where the notion that device driver should or
>   even could call VOP_REVOKE() on vnodes associated with its dev_t's
>   has originated, but it stops right here.
>
>   If there are things people belive destroy_dev() needs to learn how to
>   do, please tell me about it, preferably with a reproducible test case.
>
>   Include <sys/uio.h> in bluetooth code rather than rely on <sys/vnode.h>
>   to do so.
>
>   The fact that some of the USB code needs to include <sys/vnode.h>
>   still disturbs me greatly, but I do not have time to chase that.
>
>   Revision  Changes    Path
>   1.16      +2 -2      src/sys/dev/nmdm/nmdm.c
>   1.77      +0 -8      src/sys/dev/usb/ugen.c
>   1.63      +0 -6      src/sys/dev/usb/uhid.c
>   1.59      +0 -10     src/sys/dev/usb/ulpt.c
>   1.62      +0 -5      src/sys/dev/usb/ums.c
>   1.45      +0 -4      src/sys/dev/usb/uscanner.c
>   1.165     +1 -1      src/sys/net/if.c
>   1.8       +1 -14     src/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c
>   1.2       +1 -15     src/sys/netgraph/bluetooth/drivers/ubtbcmfw/ubtbcmfw.c
>

Unfortunately this functionality was actually required for usb to function
properly.  Did you test this with some removable devices?

Thanks,
Jeff