From owner-svn-src-all@freebsd.org Mon Dec 7 19:11:24 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 991214B1730; Mon, 7 Dec 2020 19:11:24 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CqXwX3Xjjz3QTH; Mon, 7 Dec 2020 19:11:24 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-vs1-f52.google.com (mail-vs1-f52.google.com [209.85.217.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 6C7E07301; Mon, 7 Dec 2020 19:11:24 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-vs1-f52.google.com with SMTP id s85so8197858vsc.3; Mon, 07 Dec 2020 11:11:24 -0800 (PST) X-Gm-Message-State: AOAM530ZNpKENjWbLak1mClJTf2C5CYeeQhsZu6V6w8OI8AX4Yd2gi6W db6GRIY0vBxzyHq3y0hOrsIVZ08UbukhihEnKTY= X-Google-Smtp-Source: ABdhPJy4Y4fxU6Bl/9d7EbR3SJoYycFb0Q/osAmlN4WHFGEnCThSd4I+rOQ67RBq14cBBtWl8TmRje2QN0dMTi536iM= X-Received: by 2002:a67:ea02:: with SMTP id g2mr14007260vso.3.1607368283986; Mon, 07 Dec 2020 11:11:23 -0800 (PST) MIME-Version: 1.0 References: <202011250010.0AP0AtH3061986@repo.freebsd.org> <9f48b622-2596-f3c4-0aff-f0b57e8022ea@FreeBSD.org> <43f82b24-a1d0-8e48-a405-58e8bbda0c12@FreeBSD.org> In-Reply-To: <43f82b24-a1d0-8e48-a405-58e8bbda0c12@FreeBSD.org> From: Kyle Evans Date: Mon, 7 Dec 2020 13:11:10 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r368005 - in head: lib/libprocstat share/man/man4 sys/opencrypto sys/sys tools/tools/crypto usr.bin/procstat To: John Baldwin Cc: Steve Wills , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2020 19:11:24 -0000 On Mon, Dec 7, 2020 at 12:58 PM John Baldwin wrote: > > On 12/6/20 8:51 PM, Steve Wills wrote: > > Hi, > > > > On 11/24/20 7:10 PM, John Baldwin wrote: > >> Author: jhb > >> Date: Wed Nov 25 00:10:54 2020 > >> New Revision: 368005 > >> URL: https://svnweb.freebsd.org/changeset/base/368005 > >> > >> Log: > >> Remove the cloned file descriptors for /dev/crypto. > >> > > > > Would this change warrant a bump of __FreeBSD_version? I only noticed > > because PR 251470 (radare2 not building due to KF_TYPE_CRYPTO). > > Hmm, perhaps so, though ports could also use #ifdef KF_TYPE_CRYPTO (and > that is probably preferred for anything using C). Looks like we haven't > yet had another bump of __FreeBSD_version so I can do that. > There's surely a better way, but this version bump would've actually been really handy for detecting the resulting qemu-user-static fallout. The build was broken for about ~9 days, neither the official builder or my local builder felt compelled to rebuild it absent the bump because I had just built it a couple revisions prior. =-( I'm kind of leaning towards trying to shoehorn a qemu-user-static build into ci.f.o somewhere, though, since it's used as a part of producing some of the weekly snapshot images and digs pretty deeply in other areas. I've got a Cirrus config for qemu-user-static and Cirrus builds it regularly for me, but that's not so helpful when the image it builds against is also tied to the weekly snapshot process. Thanks, Kyle Evans