From owner-freebsd-current@FreeBSD.ORG Tue Dec 13 19:36:54 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 55CAB16A41F; Tue, 13 Dec 2005 19:36:54 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB9AF43D49; Tue, 13 Dec 2005 19:36:52 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.5b3) with ESMTP id 3733879 for multiple; Tue, 13 Dec 2005 14:39:08 -0500 Received: from localhost (john@localhost [127.0.0.1]) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id jBDJakZ0050353; Tue, 13 Dec 2005 14:36:48 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: freebsd-current@freebsd.org Date: Tue, 13 Dec 2005 14:36:02 -0500 User-Agent: KMail/1.8.2 References: <20051211181324.G71610@ury.york.ac.uk> <200512131101.44375.jhb@freebsd.org> <20051213170015.GA60145@dragon.NUXI.org> In-Reply-To: <20051213170015.GA60145@dragon.NUXI.org> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200512131436.03403.jhb@freebsd.org> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV version 0.87.1, clamav-milter version 0.87 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.8 required=4.2 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx X-Server: High Performance Mail Server - http://surgemail.com r=1653887525 Cc: Gleb Smirnoff , imp@freebsd.org Subject: Re: puc fails to attach serial ports X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Dec 2005 19:36:54 -0000 On Tuesday 13 December 2005 12:00 pm, David O'Brien wrote: > On Tue, Dec 13, 2005 at 11:01:42AM -0500, John Baldwin wrote: > > Because sio(4) only includes sio_puc.c in the kernel if you have 'puc' in > > your kernel config, and the puc kernel module only includes the puc > > files, it doesn't include sio_puc.c and ppc_puc.c. uart has the same > > issue as well. Looking at the three attachments, there's no reason for > > them to be dependent on puc, they don't actually call any symbols in the > > puc(4) kernel module itself, so they can be compiled into kernels w/o puc > > without causing any harm. Then loading puc as a module would work. > > Here's a patch: > > Isn't there another way? It just seems wrong to include *_puc bits in > the kernel if you don't have 'puc' in your kernel. There are some > working on trimming down the kernel for embedded purposes and this patch > seems counter to that effort. Well, you could have sio_puc, ppc_puc, and uart_puc modules, and you could do: kldload sio_puc.ko kldload ppc_puc.ko kldload uart_puc.ko kldload puc.ko However, that type of approach will give us a huge profileration of modules and make them even less useful and a PITA to use than they are now. Also, in this case we are talking about a total of about 6 short functions (2 per device), and even then you only get them if you put sio, ppc, uart, etc. in your kernel. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org