From owner-freebsd-stable@FreeBSD.ORG Wed Oct 26 22:36:47 2005 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7D58616A420 for ; Wed, 26 Oct 2005 22:36:47 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 778DB43D5E for ; Wed, 26 Oct 2005 22:36:44 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j9QMahMh025581; Wed, 26 Oct 2005 15:36:43 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j9QMahBZ025580; Wed, 26 Oct 2005 15:36:43 -0700 Date: Wed, 26 Oct 2005 15:36:43 -0700 From: Brooks Davis To: James Long Message-ID: <20051026223643.GB7943@odin.ac.hmc.edu> References: <20051026222047.GA9467@ns.museum.rain.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="s2ZSL+KKDSLx8OML" Content-Disposition: inline In-Reply-To: <20051026222047.GA9467@ns.museum.rain.com> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: freebsd-stable@freebsd.org Subject: Re: RFC: proposed patch for /usr/src/usr.sbin/wicontrol/wicontrol.c X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Oct 2005 22:36:47 -0000 --s2ZSL+KKDSLx8OML Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 26, 2005 at 03:20:47PM -0700, James Long wrote: > wicontrol.c defaults to the "wi" interface. I used to have a > wi device, but it eventually took a dump and I bought a new > ath-based card, which works flawlessly AFAIK, after four months > or so. >=20 > But I grow weary of having to specify "-i ath0" every time I > run wicontrol. >=20 > Please review the following patch to /usr/src/usr.sbin/wicontrol/wicontro= l.c > which modifies wicontrol to look for an environment variable > WI_IFACE and if set, take the interface name from that variable. > If unset, the interface name defaults to "wi0" just as before,=20 > which hopefully will make this POLA compliant. Googling for=20 > "WI_IFACE" I find no indications that this variable name already=20 > is in use for anything else. >=20 > Apologies in advance for the simple diff output patch. wicontrol is obsolete and you should not need to use it, particularly for ath(4) devices. Why are you using it? Is some feature you need missing from ifconfig? -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --s2ZSL+KKDSLx8OML Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFDYATxXY6L6fI4GtQRAgcZAJ9gN5rYEbJ6dlfA9PjPk72aNiUr4ACfdqJt vSMUMZ9DA47IRLzCodPl2yQ= =vFA7 -----END PGP SIGNATURE----- --s2ZSL+KKDSLx8OML--