From owner-svn-src-all@FreeBSD.ORG  Mon Mar  3 14:41:15 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 242557F9;
 Mon,  3 Mar 2014 14:41:15 +0000 (UTC)
Received: from mho-02-ewr.mailhop.org (mho-02-ewr.mailhop.org [204.13.248.72])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id EAB40F4D;
 Mon,  3 Mar 2014 14:41:14 +0000 (UTC)
Received: from c-24-8-230-52.hsd1.co.comcast.net ([24.8.230.52]
 helo=damnhippie.dyndns.org)
 by mho-02-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256)
 (Exim 4.72) (envelope-from <ian@FreeBSD.org>)
 id 1WKU3N-000LHE-Nx; Mon, 03 Mar 2014 14:41:13 +0000
Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240])
 by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id s23Ef9jY046853;
 Mon, 3 Mar 2014 07:41:09 -0700 (MST) (envelope-from ian@FreeBSD.org)
X-Mail-Handler: Dyn Standard SMTP by Dyn
X-Originating-IP: 24.8.230.52
X-Report-Abuse-To: abuse@dyndns.com (see
 http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse
 reporting information)
X-MHO-User: U2FsdGVkX18JHofxiRI7TDddslqUUiSb
Subject: Re: svn commit: r262696 - head/sys/arm/arm
From: Ian Lepore <ian@FreeBSD.org>
To: Bruce Evans <brde@optusnet.com.au>
In-Reply-To: <20140303181837.I859@besplex.bde.org>
References: <201403022125.s22LPXgd078485@svn.freebsd.org>
 <20140303181837.I859@besplex.bde.org>
Content-Type: text/plain; charset="us-ascii"
Date: Mon, 03 Mar 2014 07:41:09 -0700
Message-ID: <1393857669.1149.281.camel@revolution.hippie.lan>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port 
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Mar 2014 14:41:15 -0000

On Mon, 2014-03-03 at 18:49 +1100, Bruce Evans wrote:
> On Sun, 2 Mar 2014, Ian Lepore wrote:
> 
> > Log:
> >  Add __attribute__((used)) so that the delay implementation doesn't get
> >  optimized away as unreferenced, causing linker errors when trying to
> >  resolve the weak reference to the missing function.
> 
> Why not use the standard FreeBSD macro __used?  Hard-coded
> __attribute__(())s are not only unportable; they are gross style bugs.
> They were all replaced by FreeBSD macros in old versions of FreeBSD.

Thanks.  I actually looked for __used and somehow failed to find it.

-- Ian