From owner-svn-ports-head@FreeBSD.ORG Wed Feb 5 15:56:45 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B1CAAE1D; Wed, 5 Feb 2014 15:56:45 +0000 (UTC) Received: from mail-wi0-x22b.google.com (mail-wi0-x22b.google.com [IPv6:2a00:1450:400c:c05::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7DB041879; Wed, 5 Feb 2014 15:56:44 +0000 (UTC) Received: by mail-wi0-f171.google.com with SMTP id cc10so717481wib.16 for ; Wed, 05 Feb 2014 07:56:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=ZXj6DM3xIIOsu5RJVWXyEtrA5Hkh7PBEgtHXLabwojY=; b=B+z3ppx/IcP6zTWGeDzPsRmCsAmBWEeOvy8GCAl5TPkZnCx9UsGCJU9m4f5V38pcg4 sz2Li5oj6+hYGPX6mw60W+QTTOLupLChxwRKgUR2VW3styCaxzTu+0upZn//o7r9Dvc8 vrf+8SkMNNoXBsB46eJoDfoW7aeuSaW6HSEGsNYZlBYQBhFg47ePZbpOltVzQuVGBGo3 v7dvijuBRW2pYnGjIAqSD8Bsl3DmQ8ozs4TTsEWAmp/HGxw5lLyardXfAjgs7ihhWF9i O5rHzTqVvGmPJpOUu2QpZXjLYLDoIcO1ZskuuCXPIyK4XfASv2n39p37UEGSam5MienM ML/Q== X-Received: by 10.180.76.168 with SMTP id l8mr17817492wiw.40.1391615802781; Wed, 05 Feb 2014 07:56:42 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id po3sm62444957wjc.3.2014.02.05.07.56.40 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 05 Feb 2014 07:56:41 -0800 (PST) Sender: Baptiste Daroussin Date: Wed, 5 Feb 2014 16:56:38 +0100 From: Baptiste Daroussin To: Tijl Coosemans Subject: Re: svn commit: r342718 - head/audio/libmad Message-ID: <20140205155638.GJ23872@ithaqua.etoilebsd.net> References: <201402051529.s15FTbbV098516@svn.freebsd.org> <0807AAFF65F7176953AA8581@ogg.in.absolight.net> <3A1E876406193F10101E533D@ogg.in.absolight.net> <20140205165319.06494484@kalimero.tijl.coosemans.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NqSa+Xr3J/G6Hhls" Content-Disposition: inline In-Reply-To: <20140205165319.06494484@kalimero.tijl.coosemans.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Mathieu Arnold , Sunpoet Po-Chuan Hsieh , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Feb 2014 15:56:45 -0000 --NqSa+Xr3J/G6Hhls Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 05, 2014 at 04:53:19PM +0100, Tijl Coosemans wrote: > On Wed, 05 Feb 2014 16:38:41 +0100 Mathieu Arnold wrote: > > +--On 5 f=E9vrier 2014 16:35:22 +0100 Mathieu Arnold = wrote: > >| +--On 5 f=E9vrier 2014 15:29:37 +0000 Sunpoet Po-Chuan Hsieh > >| wrote: > >|| Author: sunpoet > >|| Date: Wed Feb 5 15:29:37 2014 > >|| New Revision: 342718 > >|| URL: http://svnweb.freebsd.org/changeset/ports/342718 > >|| QAT: https://qat.redports.org/buildarchive/r342718/ > >||=20 > >|| Log: > >|| - Use USES=3Dlibtool > >||=20 > >|| Modified: > >|| head/audio/libmad/Makefile > >||=20 > >|| Modified: head/audio/libmad/Makefile > >|| =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >|| =3D=3D=3D=3D=3D --- head/audio/libmad/Makefile Wed Feb 5 15:29:04 20= 14 (r342717) > >|| +++ head/audio/libmad/Makefile Wed Feb 5 15:29:37 2014 (r342718) @@ > >|| -15,8 +15,8 @@ SPEED_DESC=3D Optimize for speed over accu > >|| =20 > >|| CONFIGURE_ARGS=3D --disable-debugging --enable-sso > >|| GNU_CONFIGURE=3D yes > >|| -USE_AUTOTOOLS=3D libtool > >|| USE_LDCONFIG=3D yes > >|| +USES=3D libtool > >|| =20 > >|| SUB_LIST=3D VERSION=3D${PORTVERSION} > >|| SUB_FILES=3D mad.pc > >||=20 > >|=20 > >| I'm quite sure you forgot to update the plist. > >=20 > > And quite possibly bump PORTREVISION in the ports that depend on it. >=20 > USES=3Dlibtool also decrements the library version in this case which > should be avoided, so you have to patch the port to decrement age until > the library version is the same as before. I've attached a patch which > does this. I don't think we should avoid decrementing shlib numbers in that case we are going back to normal situation just it needs to be chased, in my opinion. BTW: I have committed a fix regards, Bapt --NqSa+Xr3J/G6Hhls Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlLyXzYACgkQ8kTtMUmk6EzMkwCfZQwJ22kcHq6eD8VLnYXqgapo JtEAoKZ8B/MZm7n8WH+m+b5dgdBxA0vs =l+dx -----END PGP SIGNATURE----- --NqSa+Xr3J/G6Hhls--