From owner-freebsd-current@FreeBSD.ORG Thu Apr 7 20:53:17 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CEF8F1065670; Thu, 7 Apr 2011 20:53:17 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com [209.85.210.54]) by mx1.freebsd.org (Postfix) with ESMTP id 9AEC58FC15; Thu, 7 Apr 2011 20:53:17 +0000 (UTC) Received: by pzk27 with SMTP id 27so1302001pzk.13 for ; Thu, 07 Apr 2011 13:53:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=krk2NTcrV5M1I13nMnbOjE/MrvI1uJN8ymhZz/isayU=; b=VBXEsLu5UyOTBxKCsKy/BJAY9Ary2NbqlMkg5ip9d9wMqeNpLDSwenSQuwRYyArRU0 sAhnh3WA2jO0/kEoydyK29a+UZWtE+JK0oBGxy+L0qs1q0DtO8g4pJ+IudZhOANUIj1G B3XxKUkx/3qjWGVsf8WhO/olV731eNRv+J/q4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=Xh9i0bvlY0nPs8nJi02zSn3StsQC4Zb13hTKN+PjjYhJNyuw3FmA7lmrxJmW7OeoSk i2G3KQVNoL/VUjCz76IrQGlB24ZWvz7dAWvtGyUOpGkG5WwiKZe2nUo/judSbL8DG68M +h8Rq9hMvfuTlhGgkFkSzK36wK2XsX5MZ9cTU= MIME-Version: 1.0 Received: by 10.142.152.3 with SMTP id z3mr1010884wfd.398.1302209596981; Thu, 07 Apr 2011 13:53:16 -0700 (PDT) Received: by 10.68.42.3 with HTTP; Thu, 7 Apr 2011 13:53:16 -0700 (PDT) In-Reply-To: <20110407185510.GA94830@freebsd.org> References: <20110407185510.GA94830@freebsd.org> Date: Thu, 7 Apr 2011 13:53:16 -0700 Message-ID: From: Garrett Cooper To: Alexander Best Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-current@freebsd.org, freebsd-toolchain@freebsd.org Subject: Re: [RFC] adding -Wmissing-include-dirs to CWARNFLAGS X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2011 20:53:17 -0000 On Thu, Apr 7, 2011 at 11:55 AM, Alexander Best wrote: > hi there, > > i'd like to propose adding -Wmissing-include-dirs to CWARNFLAGS. this will let > tinderbox fail, if any new kernel code was committed with (a) broken include > dir(s). > > i ran a test via > > make toolchains > make MAKE_JUST_KERNELS=yes tinderbox > > and nothing seemed to go wrong with the extra warning enabled. i even found a > missing include dir, which should be fixed by the attached patch. > > opinions? > > so far i've only tested this with gcc. i think someone on #freebsd-clang told > me that -Wmissing-include-dirs is a noop for clang (for whatever reasons). make -f /etc/src.conf -VMODULES_OVERRIDE and make -f /etc/src.conf -VMODULES_OVERRIDE say... (tinderbox should also really ignore these files, but it doesn't currently)? Thanks, -Garrett