From owner-cvs-all Mon Feb 12 20:21:18 2001 Delivered-To: cvs-all@freebsd.org Received: from 200-227-201-149-as.acessonet.com.br (200-227-201-149-as.acessonet.com.br [200.227.201.149]) by hub.freebsd.org (Postfix) with ESMTP id 1B57637B4EC for ; Mon, 12 Feb 2001 20:21:09 -0800 (PST) Received: (qmail 4675 invoked by uid 1001); 13 Feb 2001 04:21:15 -0000 From: "Mario Sergio Fujikawa Ferreira" Date: Tue, 13 Feb 2001 02:20:53 -0200 To: Maxim Sobolev Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/graphics/avifile Makefile distinfo pkg-plist Message-ID: <20010213022053.A3912@Fedaykin.here> References: <200102130238.f1D2cCa94261@freefall.freebsd.org> <200102130352.f1D3qE953186@vic.sabbo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200102130352.f1D3qE953186@vic.sabbo.net>; from sobomax@FreeBSD.org on Tue, Feb 13, 2001 at 05:51:47AM +0200 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > Please considring attached patch. Thanks for the prompt patch. A doubt, though, before I move. Why is the following not working? This surely looks fine. Why is ${PORTSDIR} not being expanded correctly? The only thing broken there is the CODEC_PORT var due to PORTSDIR not being expanded. Why? As per the CODEC_DETECTION_FILE, I do believe it is a bikeshed though both are not isomorph. Just check mail/qmail-ldap for an example where using the second form brakes it. But I can appreciate that it is more aestheticaly pleasant. I can use the second. I was just wondering why it is better. I am just clueless as to why, this is not cinicism. Content-Description: ASCII text > Index: Makefile > =================================================================== > RCS file: /home/ncvs/ports/graphics/avifile/Makefile,v > retrieving revision 1.10 > diff -d -u -r1.10 Makefile > --- Makefile 2001/02/13 02:38:12 1.10 > +++ Makefile 2001/02/13 03:51:34 > @@ -38,9 +38,8 @@ > > FMT= /usr/bin/fmt > > -CODEC_PORT= ${PORTSDIR}/graphics/win32-codecs > -#CODEC_PORT= ../win32-codecs > -CODEC_DETECTION_FILE!= cd ${CODEC_PORT} && ${MAKE} -V CODEC_DETECTION_FILE > +CODEC_PORT= ${.CURDIR}/../../graphics/win32-codecs > +CODEC_DETECTION_FILE!= ${MAKE} -f ${CODEC_PORT}/Makefile -V CODEC_DETECTION_FILE > > LIB_VERSION= 0 > # Adhoc fix. First part. Thanks, -- Mario S F Ferreira - UnB - Brazil - "I guess this is a signature." lioux at ( freebsd dot org | linf dot unb dot br ) flames to beloved devnull@someotherworldbeloworabove.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message