From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Aug 2 23:21:54 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 43D8216A4FA for ; Wed, 2 Aug 2006 23:21:54 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1A54343E1C for ; Wed, 2 Aug 2006 23:20:26 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k72NKGYd005533 for ; Wed, 2 Aug 2006 23:20:16 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k72NKGSa005532; Wed, 2 Aug 2006 23:20:16 GMT (envelope-from gnats) Resent-Date: Wed, 2 Aug 2006 23:20:16 GMT Resent-Message-Id: <200608022320.k72NKGSa005532@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Gabor Kovesdan Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C085A16A50C; Wed, 2 Aug 2006 23:19:59 +0000 (UTC) (envelope-from root@catv-50635cb6.catv.broadband.hu) Received: from catv-50635cb6.catv.broadband.hu (catv-50635cb6.catv.broadband.hu [80.99.92.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 813BE43E84; Wed, 2 Aug 2006 23:18:50 +0000 (GMT) (envelope-from root@catv-50635cb6.catv.broadband.hu) Received: by catv-50635cb6.catv.broadband.hu (Postfix, from userid 0) id 53F5C289EF1; Thu, 3 Aug 2006 01:18:48 +0200 (CEST) Message-Id: <20060802231848.53F5C289EF1@catv-50635cb6.catv.broadband.hu> Date: Thu, 3 Aug 2006 01:18:48 +0200 (CEST) From: Gabor Kovesdan To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Gabor Kovesdan Subject: ports/101285: [patch] audio/icecast2 - fix rc.d script X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Gabor Kovesdan List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 23:21:54 -0000 >Number: 101285 >Category: ports >Synopsis: [patch] audio/icecast2 - fix rc.d script >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Aug 02 23:20:16 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Gabor Kovesdan >Release: FreeBSD 6.1-STABLE i386 >Organization: n/a >Environment: System: FreeBSD spitfire 6.1-STABLE FreeBSD 6.1-STABLE #0: Sat Jul 29 18:31:18 CEST 2006 gabor@spitfire:/usr/src/sys/i386/compile/SPITFIRE i386 >Description: The rc.d script of audio/icecast doesn't work as intended, the -b command line option is not passed when invoking the script. >How-To-Repeat: Run the rc.d script with sh -x and you will be able to notice it: + [ start != start ] + eval _cmd=$start_cmd _precmd=$start_precmd _postcmd=$start_postcmd + _cmd= _precmd= _postcmd= + [ -n ] + [ -z -a -n ] + [ ! -x /usr/local/bin/icecast ] + [ ! -r /usr/local/etc/icecast.xml ] + [ -n ] + echo Starting icecast. Starting icecast. + [ -n ] + _doit=/usr/local/bin/icecast -c /usr/local/etc/icecast.xml 1>/dev/null + [ -n ] + debug run_rc_command: _doit: /usr/local/bin/icecast -c /usr/local/etc/icecast.xml 1>/dev/null + eval /usr/local/bin/icecast -c /usr/local/etc/icecast.xml 1>/dev/null + /usr/local/bin/icecast -c /usr/local/etc/icecast.xml >Fix: --- audio-icecast2.diff begins here --- Index: audio/icecast2/Makefile =================================================================== RCS file: /usr/cvs/ports/audio/icecast2/Makefile,v retrieving revision 1.52 diff -u -r1.52 Makefile --- audio/icecast2/Makefile 7 May 2006 02:57:32 -0000 1.52 +++ audio/icecast2/Makefile 2 Aug 2006 23:14:03 -0000 @@ -7,7 +7,7 @@ PORTNAME= icecast2 PORTVERSION= 2.3.1 -PORTREVISION= 2 +PORTREVISION= 3 PORTEPOCH= 1 CATEGORIES= audio net ipv6 MASTER_SITES= http://svn.xiph.org/releases/icecast/ Index: audio/icecast2/files/icecast2.sh.in =================================================================== RCS file: /usr/cvs/ports/audio/icecast2/files/icecast2.sh.in,v retrieving revision 1.3 diff -u -r1.3 icecast2.sh.in --- audio/icecast2/files/icecast2.sh.in 20 Feb 2006 20:46:48 -0000 1.3 +++ audio/icecast2/files/icecast2.sh.in 2 Aug 2006 23:13:54 -0000 @@ -23,12 +23,12 @@ rcvar=`set_rcvar` command="%%PREFIX%%/bin/icecast" -command_args="1>/dev/null" +command_args="-b 1>/dev/null" required_files="%%PREFIX%%/etc/$name.xml" # read configuration and set defaults load_rc_config "$name" : ${icecast_enable="NO"} -: ${icecast_flags="-c ${required_files} -b"} +: ${icecast_flags="-c ${required_files}"} run_rc_command "$1" --- audio-icecast2.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: