From owner-freebsd-mips@FreeBSD.ORG Fri Jun 18 05:59:53 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CDE32106566C; Fri, 18 Jun 2010 05:59:53 +0000 (UTC) (envelope-from c.jayachandran@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 63ACD8FC13; Fri, 18 Jun 2010 05:59:53 +0000 (UTC) Received: by vws20 with SMTP id 20so11135914vws.13 for ; Thu, 17 Jun 2010 22:59:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=dnDrKhqWJfCeOOCfPTR30IAp+8pLHB+AGUMawzvOPVA=; b=Ug/zJnlkKMuP6skFRYMVKQFnM9hLUmoR9964J9mJo7qsQ2MI+IEWTLa5ED7DKN1pa5 3cFZfU2nUBgLcyTrLdydTUAxMBWbGCu6/BUAm4H0HeTuqStVW8Rtc+o+TQVlGPxKppmw 6lqHMo0yYohUDJER4Tx2FWqSYVRo8yOc5JffM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=lZQgNsonRcLfSwwXdNoM7EDMOkxkU/SgrvePh6MFkoOMcqKBBv1Sjrw8V3BMo03uiB PH1bbKEGiFHiavtgrW4yJQUAu2BW2zx3viHl/Y/nPh1tJ2Mrlv+D/WFvwfBpLgesQC3Q gmz2W4cU2KZzhvuK97kn2WTt13DosRwnAJdE0= MIME-Version: 1.0 Received: by 10.220.63.12 with SMTP id z12mr330058vch.260.1276840792550; Thu, 17 Jun 2010 22:59:52 -0700 (PDT) Received: by 10.220.199.200 with HTTP; Thu, 17 Jun 2010 22:59:52 -0700 (PDT) In-Reply-To: <763BEBBB-B85A-44CE-BFEE-0BADEFF3C185@lakerest.net> References: <20100617.100235.195066307596264499.imp@bsdimp.com> <4B66E1A4-E2A5-471F-9FA4-38B506797272@lakerest.net> <20100617.110504.200754750200158040.imp@bsdimp.com> <763BEBBB-B85A-44CE-BFEE-0BADEFF3C185@lakerest.net> Date: Fri, 18 Jun 2010 11:29:52 +0530 Message-ID: From: "Jayachandran C." To: Randall Stewart Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Alan Cox , freebsd-mips@freebsd.org Subject: Re: Merging 64 bit changes to -HEAD - part 2 X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2010 05:59:53 -0000 On Fri, Jun 18, 2010 at 4:00 AM, Randall Stewart wrote: > > On Jun 17, 2010, at 1:05 PM, M. Warner Losh wrote: >> >> It was also a name-space collision, so we were using PG_x instead of >> PG_y in the PTE code due to the overlap. =A0Maybe it all works now, but >> that was the motivation for the change. > > > > Yes, basically if I remember right someone used > > PG_GLOBAL instead of PG_G. This caused the wrong bits > to be set. > > In general I think its a BAD idea to have two name spaces in the > same section of the system (VM) that have similar define's that mean > different things. > > > Far better to KEEP the PTE_xxx or for that matter pick something else.. J= ust > NOT PG_xxx I was not aware of the PG/PTE history, I thought I would get the diffs against Juli's tree down. I will drop the renaming patch. But can you review/approve the second patch. This change removes the sched_pin and lock in the LMEM macros.My understanding is that, these are not needed because each cpu is given its own va to map the physical memory to, and this pa/va mapping in in the kernel_pmap. JC.