From owner-cvs-src@FreeBSD.ORG Wed May 16 07:43:50 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8BC1416A405; Wed, 16 May 2007 07:43:50 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 4000A13C45A; Wed, 16 May 2007 07:43:50 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from outgoing.leidinger.net (p54A5FC6A.dip.t-dialin.net [84.165.252.106]) by redbull.bpaserver.net (Postfix) with ESMTP id 7475A2E1DC; Wed, 16 May 2007 09:43:46 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id AC6B55B48A3; Wed, 16 May 2007 09:43:30 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.13.8/8.13.8/Submit) id l4G7hURZ005494; Wed, 16 May 2007 09:43:30 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Wed, 16 May 2007 09:43:30 +0200 Message-ID: <20070516094330.dkp2e41vdc0w8kg8@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Wed, 16 May 2007 09:43:30 +0200 From: Alexander Leidinger To: Dag-Erling =?utf-8?b?U23Dg8K4cmdyYXY=?= References: <200705131815.l4DIFop9026874@repoman.freebsd.org> <20070514154040.0lofzrgm8kskgog4@webmail.leidinger.net> <86wszbqxbz.fsf@dwp.des.no> <20070514172938.5v4yi78kisokk84s@webmail.leidinger.net> <861whiy5ra.fsf@dwp.des.no> In-Reply-To: <861whiy5ra.fsf@dwp.des.no> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.564, required 8, BAYES_00 -15.00, DK_POLICY_SIGNSOME 0.00, FORGED_RCVD_HELO 0.14, MIME_8BIT_HEADER 0.30) X-BPAnet-MailScanner-From: alexander@leidinger.net X-Spam-Status: No Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 May 2007 07:43:50 -0000 Quoting Dag-Erling Sm=C3=83=C2=B8rgrav (from Tue, 15 May 2007 = =20 08:12:41 +0200): > Alexander Leidinger writes: >> Dag-Erling Smorgrav writes: >> > Alexander Leidinger writes: >> > > Why did you remove the echo? >> > which echo? about schg? it was completely bogus. >> Yes. I don't think so, please explain. > > It would show up incorrectly if you declined to remove a file. > >> > feel free to re-add it, but only if you also add logic to check whether >> > the file actually has the schg flag set before running chflags. >> In the current code it doesn't make sense, and the wording can be >> changed to tell that it will remove schg, in case this flag is set. As >> you did the change and I don't have time to commit such a change when >> I'm back at home (the place where I can make commits), would you >> please add the echo again? > > That would mean an extra line of output for every single file... What about another idea: removing the chflags all together and let the =20 removal fail (with a message that the file may be protected with schg =20 and it should be removed with chglags). This way only a message =20 appears when the rm fails (saying no to the removal question of rm is =20 not a failure/exit!=3D0). >> > > - bug(?): ${DESTDIR} in the rm line >> > no, this is intentional, and in fact the original code had it too. >> The original code hat it before, but you CD into DESTDIR, so it is not >> necessary anymore. > > Unless someone goofs and adds an absolute path to ObsoleteFiles.inc... > which is why I very deliberately left "${DESTDIR}/" in front of the path > in the rm command, although I could probably replace it with "./". That would make it more consistent. Bye, Alexander. --=20 War doesn't prove who's right, just who's left. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137