From owner-freebsd-ports-bugs@FreeBSD.ORG  Wed May 14 21:00:01 2014
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 3A86068E
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Wed, 14 May 2014 21:00:01 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 2818F299B
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Wed, 14 May 2014 21:00:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s4EL01RO024958
 for <freebsd-ports-bugs@freefall.freebsd.org>; Wed, 14 May 2014 21:00:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s4EL00as024957;
 Wed, 14 May 2014 21:00:01 GMT (envelope-from gnats)
Date: Wed, 14 May 2014 21:00:01 GMT
Message-Id: <201405142100.s4EL00as024957@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
Cc: 
From: Guido Falsi <madpilot@FreeBSD.org>
Subject: Re: ports/189777: [patch] www/codeigniter staging, change url
Reply-To: Guido Falsi <madpilot@FreeBSD.org>
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 May 2014 21:00:01 -0000

The following reply was made to PR ports/189777; it has been noted by GNATS.

From: Guido Falsi <madpilot@FreeBSD.org>
To: bug-followup@FreeBSD.org, udvzsolt@gmail.com, appleboy.tw@gmail.com
Cc:  
Subject: Re: ports/189777: [patch] www/codeigniter staging, change url
Date: Wed, 14 May 2014 22:51:19 +0200

 While looking at this patch I noticed it has a problem.
 
 The staging conversion is incomplete.
 
 The port is still echoing pkg-message by itself, which is unnecessary
 with staging.
 
 The port also echoes various user message during installation, this is
 wrong when using staging, since thee messages will appear at the wrong
 time, and will never be seen by people using binary packages.
 
 Such messages should be moved to the pkg-message, or, is conditionally
 shown, a pkg-install script should be created to show them if necessary.
 
 Can this patch be fixed keeping all this in mind?
 
 The port is also redefining WWWDIR to it's default value, why is this
 needed?
 
 Thanks in advance.
 
 -- 
 Guido Falsi <madpilot@FreeBSD.org>