From owner-freebsd-current@FreeBSD.ORG  Thu Apr  7 20:53:37 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 66E5A1065679;
	Thu,  7 Apr 2011 20:53:37 +0000 (UTC)
	(envelope-from yanegomi@gmail.com)
Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com
	[209.85.210.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 2F4358FC1B;
	Thu,  7 Apr 2011 20:53:37 +0000 (UTC)
Received: by pzk27 with SMTP id 27so1302126pzk.13
	for <multiple recipients>; Thu, 07 Apr 2011 13:53:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:in-reply-to:references:date
	:message-id:subject:from:to:cc:content-type
	:content-transfer-encoding;
	bh=agrjJ6GUNGo2kuf28fWJpwfUMzF8D0AaiqE9p3tshag=;
	b=f6JPgs6XxqmYMKCcTb1r0llJYgsxlF8m2bamh0MxlrKo/ijlBVfu2v9TzudK3j8eMY
	RY1D0Ua3KorhveMKAnITDcDdMBrCHFJvOlOJ5Eue4ZH74NzapbxdVIhDx0frEk1dsV5M
	3Hk+rJUbgjdf5d65nx/5TTjOmacxzo6hKBpEE=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type:content-transfer-encoding;
	b=B2pkT9a5UDpfao8HvihQ3g38kl9FmpwVEUHxKssEJFTFmE23LYytZLcLzT8WHCJ+pv
	b8QEv3H3gVCLO34NwI1U8LBudLkVNabO0QWpue1Uo4n7dwMhlQKQy9bfwkZdBz1cHDac
	7vArGWLy12i+hon6tByBDoA2fLhZKel4tzqsg=
MIME-Version: 1.0
Received: by 10.142.136.18 with SMTP id j18mr974943wfd.284.1302209616772; Thu,
	07 Apr 2011 13:53:36 -0700 (PDT)
Received: by 10.68.42.3 with HTTP; Thu, 7 Apr 2011 13:53:36 -0700 (PDT)
In-Reply-To: <BANLkTinWdMf3jXa=zk4Yi08oW4Du4zzeFg@mail.gmail.com>
References: <20110407185510.GA94830@freebsd.org>
	<BANLkTinWdMf3jXa=zk4Yi08oW4Du4zzeFg@mail.gmail.com>
Date: Thu, 7 Apr 2011 13:53:36 -0700
Message-ID: <BANLkTinPqjG5EigkULVrXaK5pCAN+js00w@mail.gmail.com>
From: Garrett Cooper <yanegomi@gmail.com>
To: Alexander Best <arundel@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: freebsd-current@freebsd.org, freebsd-toolchain@freebsd.org
Subject: Re: [RFC] adding -Wmissing-include-dirs to CWARNFLAGS
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Apr 2011 20:53:37 -0000

On Thu, Apr 7, 2011 at 1:53 PM, Garrett Cooper <yanegomi@gmail.com> wrote:
> On Thu, Apr 7, 2011 at 11:55 AM, Alexander Best <arundel@freebsd.org> wro=
te:
>> hi there,
>>
>> i'd like to propose adding -Wmissing-include-dirs to CWARNFLAGS. this wi=
ll let
>> tinderbox fail, if any new kernel code was committed with (a) broken inc=
lude
>> dir(s).
>>
>> i ran a test via
>>
>> make toolchains
>> make MAKE_JUST_KERNELS=3Dyes tinderbox
>>
>> and nothing seemed to go wrong with the extra warning enabled. i even fo=
und a
>> missing include dir, which should be fixed by the attached patch.
>>
>> opinions?
>>
>> so far i've only tested this with gcc. i think someone on #freebsd-clang=
 told
>> me that -Wmissing-include-dirs is a noop for clang (for whatever reasons=
).
>
> =A0 =A0make -f /etc/src.conf -VMODULES_OVERRIDE and make -f /etc/src.conf
> -VMODULES_OVERRIDE say... (tinderbox should also really ignore these
> files, but it doesn't currently)?

Sorry. Second invocation should have been make.conf, not src.conf.