From owner-cvs-all@FreeBSD.ORG Sun Sep 28 14:27:13 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0657E16A4B3; Sun, 28 Sep 2003 14:27:13 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6979843FFD; Sun, 28 Sep 2003 14:27:09 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h8SLR5LG000867; Sun, 28 Sep 2003 23:27:05 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Jeff Roberson From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sun, 28 Sep 2003 17:09:52 EDT." <20030928170907.A99666-100000@mail.chesapeake.net> Date: Sun, 28 Sep 2003 23:27:05 +0200 Message-ID: <866.1064784425@critter.freebsd.dk> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if.c src/sys/dev/nmdm nmdm.c src/sys/dev/usb ugen.c uhid.c ulpt.c ums.c uscanner.c src/sys/netgraph/bluetooth/drivers/ubt ng_ubt.c src/sys/netgraph/bluetooth/dr X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Sep 2003 21:27:13 -0000 In message <20030928170907.A99666-100000@mail.chesapeake.net>, Jeff Roberson wr ites: > >Unfortunately this functionality was actually required for usb to function >properly. Did you test this with some removable devices? I can't see how USB removable devices would (or should) differ from any other removable device in this respect, so I have not performed any testing. I simply removed this gross layering violation when it gave me my first panic. If USB has needs not catered for by make_dev()/destroy_dev() I would like to know what they are, rather than see gross hacks like this. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.