From owner-svn-ports-head@FreeBSD.ORG Thu Sep 5 03:47:44 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 94565FB4 for ; Thu, 5 Sep 2013 03:47:44 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 634AB23D7 for ; Thu, 5 Sep 2013 03:47:44 +0000 (UTC) Received: by mail-pa0-f48.google.com with SMTP id kp13so1325776pab.7 for ; Wed, 04 Sep 2013 20:47:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=9sUcwkQx7uzGzDDVnSKdF1ZQwByOiYKzZnzswbuErgc=; b=lGBlBVnbp1hOU0kQ68Y7xCw7B9YBHyoaFvs9s2SiFZ59CxgBiePFeshxNjfQXdUkfM qLv6H6GTg0dmCwwHFSOUZI1MNlUCxptBXGgploQMvcOMxAiN1To2hZoHBi2aoHLEKBy2 K/cGdoTsTiy6pH+pnKkOHTO6wQDGN7BvRdg8Sf0k+Lxkv4sZCugdeNvpSu47EzBSUTnv 0NsUrWfqJ8iBCD0d0kgfOboVRyO6jYas6xwu2NGuUS6YAZ2Ng8J0p/eBrps+8zWwCIxk jwAXkMTiCnOCd5h52xvYBYzJ7u1MLKEqCvetdBNFjuQPfR5EadYMWR0C7c3nM+Jycbuz 0KIw== X-Gm-Message-State: ALoCoQkH6lhX0gWHILbPwxwNI/nt50gipiiUdtw4YM3kDucBVXf6KdK5RqFmeocUaU4BR8iYEC5o MIME-Version: 1.0 X-Received: by 10.66.145.166 with SMTP id sv6mr6846077pab.31.1378352858363; Wed, 04 Sep 2013 20:47:38 -0700 (PDT) Sender: bsd-src@helfman.org Received: by 10.70.100.165 with HTTP; Wed, 4 Sep 2013 20:47:38 -0700 (PDT) In-Reply-To: References: <201309040646.r846kOiI053502@svn.freebsd.org> Date: Wed, 4 Sep 2013 20:47:38 -0700 X-Google-Sender-Auth: 8B-P-Pk9B2ERE4RgEqx6y6Ah8ng Message-ID: Subject: Re: svn commit: r326253 - head/games/p5-Games-Dice From: Jason Helfman To: Sunpoet Po-Chuan Hsieh Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , Jason Helfman , Andrej Zverev , "ports-committers@freebsd.org" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 03:47:44 -0000 On Wed, Sep 4, 2013 at 8:29 AM, Sunpoet Po-Chuan Hsieh wrote: > On Wed, Sep 4, 2013 at 2:59 PM, Andrej Zverev wrote: > >> On Wed, Sep 4, 2013 at 10:46 AM, Jason Helfman wrote: >> > Author: jgh >> > Date: Wed Sep 4 06:46:23 2013 >> > New Revision: 326253 >> > URL: http://svnweb.freebsd.org/changeset/ports/326253 >> > >> > Log: >> > - update to 0.043 >> > - adoption of perl USES framework >> > - adjust dependencies >> > >> > PR: 181770 >> > Submitted by: danilogondolfo@gmail.com ( maintainer ) >> > >> >> > >> > +BUILD_DEPENDS= p5-Capture-Tiny>=0:${PORTSDIR}/devel/p5-Capture-Tiny \ >> > + p5-Test-Script>=1.06:${PORTSDIR}/devel/p5-Test-Script \ >> > + p5-Test-Simple>=0.96:${PORTSDIR}/devel/p5-Test-Simple >> >> We try not to add to the Test:: namespace into (RUN|BUILD)_DEPENDS for >> p5- and what you need only for the tests (t/*). In this case, I do not >> see why it's done. >> > > These three perl modules are all test-only dependencies. We have > TEST_DEPENDS [1] for this purpose. At least tinderbox recognizes it. > > [1] https://wiki.freebsd.org/Perl#Test_Dependencies > Originally, I had thought about adding these in as TEST_DEPENDS, but found it wasn't documented anywhere in ports framework, or the handbook. That being said, buildlogs for the port, itself, also showed failure on an incomplete kit using pourdiere. I don't know if this is expected, or if this is an issue with configuration of the software for a build mode vs. a test mode. How does this diff look? -jgh Index: games/p5-Games-Dice/Makefile =================================================================== --- games/p5-Games-Dice/Makefile (revision 326340) +++ games/p5-Games-Dice/Makefile (working copy) @@ -3,6 +3,7 @@ PORTNAME= Games-Dice PORTVERSION= 0.043 +PORTREVISION= 1 CATEGORIES= games perl5 MASTER_SITES= CPAN PKGNAMEPREFIX= p5- @@ -12,7 +13,7 @@ LICENSE= MIT -BUILD_DEPENDS= p5-Capture-Tiny>=0:${PORTSDIR}/devel/p5-Capture-Tiny \ +TEST_DEPENDS= p5-Capture-Tiny>=0:${PORTSDIR}/devel/p5-Capture-Tiny \ p5-Test-Script>=1.06:${PORTSDIR}/devel/p5-Test-Script \ p5-Test-Simple>=0.96:${PORTSDIR}/devel/p5-Test-Simple -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serve