From owner-freebsd-mips@FreeBSD.ORG Fri Jun 18 19:41:40 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E94FE106566C for ; Fri, 18 Jun 2010 19:41:40 +0000 (UTC) (envelope-from neelnatu@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id A6B658FC14 for ; Fri, 18 Jun 2010 19:41:40 +0000 (UTC) Received: by iwn7 with SMTP id 7so1758897iwn.13 for ; Fri, 18 Jun 2010 12:41:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=vrYRIUzPkXA+aM9iHp56YYepMkigNM84KP4chygPU3c=; b=Un8lcVrgjMFxNVZnt1Afj15IwwGk40lNiQ17gYy9M+w89FgRDf8EChsjoUb1gq9ucQ PYUe7VUW95ZUdn0oq6EtREdF9wrUusRIv5YE8n+iO3amZtdnTyOk9Yh97EEyqDGo8avI 72LYWHDUVdABdgfKzGFt7RlDEbjdHXDR8O7r0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=pUQ6zLfkZ3lhj+c45YdxKuHbz7N6LTaDpjv0qPITszce2TYP5bwDjv+uM861oRffZN VdkETpWILYhD0XzCi6JLu8307K51/A8spSXCKyQ98S007RSOrzJTzhXxDY1wfwMCm005 SSQDVbvFmE8ifPX26huqVJOXTMTCPr9N624fQ= MIME-Version: 1.0 Received: by 10.231.130.162 with SMTP id t34mr1634465ibs.157.1276890099961; Fri, 18 Jun 2010 12:41:39 -0700 (PDT) Received: by 10.231.32.197 with HTTP; Fri, 18 Jun 2010 12:41:39 -0700 (PDT) In-Reply-To: References: <20100617.100235.195066307596264499.imp@bsdimp.com> <4B66E1A4-E2A5-471F-9FA4-38B506797272@lakerest.net> <20100617.110504.200754750200158040.imp@bsdimp.com> <763BEBBB-B85A-44CE-BFEE-0BADEFF3C185@lakerest.net> Date: Fri, 18 Jun 2010 12:41:39 -0700 Message-ID: From: Neel Natu To: "Jayachandran C." Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Alan Cox , freebsd-mips@freebsd.org Subject: Re: Merging 64 bit changes to -HEAD - part 2 X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2010 19:41:41 -0000 Hi JC, On Thu, Jun 17, 2010 at 10:59 PM, Jayachandran C. wrote: > On Fri, Jun 18, 2010 at 4:00 AM, Randall Stewart wrote= : >> >> On Jun 17, 2010, at 1:05 PM, M. Warner Losh wrote: >>> >>> It was also a name-space collision, so we were using PG_x instead of >>> PG_y in the PTE code due to the overlap. =A0Maybe it all works now, but >>> that was the motivation for the change. >> >> >> >> Yes, basically if I remember right someone used >> >> PG_GLOBAL instead of PG_G. This caused the wrong bits >> to be set. >> >> In general I think its a BAD idea to have two name spaces in the >> same section of the system (VM) that have similar define's that mean >> different things. >> >> >> Far better to KEEP the PTE_xxx or for that matter pick something else.. = Just >> NOT PG_xxx > > I was not aware of the PG/PTE history, I thought I would get the diffs > against Juli's tree down. > > I will drop the renaming patch. > > But can you review/approve the second patch. =A0This change removes the > sched_pin and lock in the LMEM macros.My understanding is that, these > are not needed because each cpu is given its own va to map the > physical memory to, and this pa/va mapping in in the kernel_pmap. > Your second patch as it stands looks good. But what you really want here is to eliminate the intr_disable() and intr_restore() and keep sched_pin() and sched_unpin(). The interrupt disable hack was necessary when we would directly update the TLB with the temporary mappings as opposed to going through the kernel_pmap as we do now. By instantiating the temporary mappings in the kernel pmap we can rely on the TLB miss handler to put these mappings in the TLB in case they get removed because of interrupt processing. See this change that introduced the interrupt disable code: http://svn.freebsd.org/viewvc/base?view=3Drevision&revision=3D203151 best Neel > JC. > _______________________________________________ > freebsd-mips@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-mips > To unsubscribe, send any mail to "freebsd-mips-unsubscribe@freebsd.org" >