From owner-p4-projects@FreeBSD.ORG  Mon Jun 14 20:27:02 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id B906D1065680; Mon, 14 Jun 2010 20:27:02 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7D552106567D
	for <perforce@FreeBSD.org>; Mon, 14 Jun 2010 20:27:02 +0000 (UTC)
	(envelope-from hselasky@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 6B42C8FC18
	for <perforce@FreeBSD.org>; Mon, 14 Jun 2010 20:27:02 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o5EKR2vG072214
	for <perforce@FreeBSD.org>; Mon, 14 Jun 2010 20:27:02 GMT
	(envelope-from hselasky@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o5EKR2S0072212
	for perforce@freebsd.org; Mon, 14 Jun 2010 20:27:02 GMT
	(envelope-from hselasky@FreeBSD.org)
Date: Mon, 14 Jun 2010 20:27:02 GMT
Message-Id: <201006142027.o5EKR2S0072212@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	hselasky@FreeBSD.org using -f
From: Hans Petter Selasky <hselasky@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 179620 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Jun 2010 20:27:03 -0000

http://p4web.freebsd.org/@@179620?ac=10

Change 179620 by hselasky@hselasky_laptop001 on 2010/06/14 20:26:38

	USB MIDI:
		- Reduce MIDI input buffer size to one
		USB packet, hence some USB devices
		don't properly short terminate their
		transfers. This fixes a problem where
		input appears several seconds late.
	
		- Reported by: Alexander Yerenkow
		- Fix by: hselasky @

Affected files ...

.. //depot/projects/usb/src/sys/dev/sound/usb/uaudio.c#71 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/sound/usb/uaudio.c#71 (text+ko) ====

@@ -507,8 +507,8 @@
 		.type = UE_BULK,
 		.endpoint = UE_ADDR_ANY,
 		.direction = UE_DIR_IN,
-		.bufsize = UMIDI_BULK_SIZE,
-		.flags = {.pipe_bof = 1,.short_xfer_ok = 1,},
+		.bufsize = 4,	/* bytes */
+		.flags = {.pipe_bof = 1,.short_xfer_ok = 1,.proxy_buffer = 1,},
 		.callback = &umidi_bulk_read_callback,
 	},
 
@@ -3316,10 +3316,6 @@
 
 		DPRINTF("actlen=%d bytes\n", actlen);
 
-		if (actlen == 0) {
-			/* should not happen */
-			goto tr_error;
-		}
 		pos = 0;
 		pc = usbd_xfer_get_frame(xfer, 0);
 
@@ -3354,8 +3350,6 @@
 		return;
 
 	default:
-tr_error:
-
 		DPRINTF("error=%s\n", usbd_errstr(error));
 
 		if (error != USB_ERR_CANCELLED) {