From owner-svn-ports-head@FreeBSD.ORG  Fri Jan 17 10:47:38 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id BBB5979C;
 Fri, 17 Jan 2014 10:47:38 +0000 (UTC)
Received: from prod2.absolight.net (mx3.absolight.net
 [IPv6:2a01:678:2:100::25])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7FDED15BA;
 Fri, 17 Jan 2014 10:47:38 +0000 (UTC)
Received: from prod2.absolight.net (localhost [127.0.0.1])
 by prod2.absolight.net (Postfix) with ESMTP id AB181BDC71;
 Fri, 17 Jan 2014 11:47:35 +0100 (CET)
Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205])
 by prod2.absolight.net (Postfix) with ESMTPA id 83E70BDC70;
 Fri, 17 Jan 2014 11:47:35 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by atuin.in.mat.cc (Postfix) with ESMTP id 80FB2CC809A2;
 Fri, 17 Jan 2014 11:47:33 +0100 (CET)
Date: Fri, 17 Jan 2014 11:47:30 +0100
From: Mathieu Arnold <mat@FreeBSD.org>
To: Pietro Cerutti <gahr@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r340026 - head/net-im/libpurple
Message-ID: <884B7C619AAEEC285129466D@atuin.in.mat.cc>
In-Reply-To: <201401171033.s0HAX99I020937@svn.freebsd.org>
References: <201401171033.s0HAX99I020937@svn.freebsd.org>
X-Mailer: Mulberry/4.0.8 (Mac OS X)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jan 2014 10:47:38 -0000

+--On 17 janvier 2014 10:33:09 +0000 Pietro Cerutti <gahr@FreeBSD.org>
wrote:
|  .if ${PORT_OPTIONS:MTCLTK}
| -USE_TK=			yes
| -CFLAGS+=		-I${LOCALBASE}/include/tk${TK_VER}
| -I${LOCALBASE}/include/tcl${TCL_VER} -CONFIGURE_ARGS+=
| 	--with-tclconfig=${LOCALBASE}/lib/tcl${TCL_VER} \ -
| 	--with-tkconfig=${LOCALBASE}/lib/tk${TK_VER}
| +USES+=			tk
| +CFLAGS+=		-I${TK_INCLUDEDIR} -I${TCL_INCLUDEDIR}
| +CONFIGURE_ARGS+=	--with-tclconfig=${TCL_LIBDIR} \
| +			--with-tkconfig=${TK_LIBDIR}

Which is way better written as :

TCLTK_USES=             tk
TCLTK_CFLAGS=		-I${TK_INCLUDEDIR} -I${TCL_INCLUDEDIR}
TCLTK_CONFIGURE_ON=	--with-tclconfig=${TCL_LIBDIR} \
			--with-tkconfig=${TK_LIBDIR}

-- 
Mathieu Arnold