From owner-freebsd-current Sun Dec 17 15: 7:54 2000 From owner-freebsd-current@FreeBSD.ORG Sun Dec 17 15:07:51 2000 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from pike.osd.bsdi.com (pike.osd.bsdi.com [204.216.28.222]) by hub.freebsd.org (Postfix) with ESMTP id D097237B400; Sun, 17 Dec 2000 15:07:50 -0800 (PST) Received: from foo.osd.bsdi.com (root@foo.osd.bsdi.com [204.216.28.137]) by pike.osd.bsdi.com (8.11.1/8.9.3) with ESMTP id eBHN7VE86583; Sun, 17 Dec 2000 15:07:31 -0800 (PST) (envelope-from jhb@foo.osd.bsdi.com) Received: (from jhb@localhost) by foo.osd.bsdi.com (8.11.1/8.11.0) id eBHN6eu74498; Sun, 17 Dec 2000 15:06:40 -0800 (PST) (envelope-from jhb) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <3A3D2CFD.8572F575@gorean.org> Date: Sun, 17 Dec 2000 15:06:40 -0800 (PST) Organization: BSD, Inc. From: John Baldwin To: Doug Barton Subject: Re: test/review: /dev/console logging patch Cc: current@FreeBSD.ORG, Poul-Henning Kamp Sender: jhb@foo.osd.bsdi.com Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 17-Dec-00 Doug Barton wrote: > Poul-Henning Kamp wrote: >> >> This patch is for the printf(9), log(9) & /dev/console stuff. >> The result is that you can watch the output from /etc/rc in >> your /var/log/messages. > > This works spectacularly for me on a UP -current with up to date > sources. The only nit I have is that it doesn't understand lines that > don't end in a newline very well (such as echo -n, or a printf with no > \n), so it produces log output like this: > > Dec 17 13:00:24 Master /boot/kernel/kernel: /dev/da1s1a: > Dec 17 13:00:24 Master /boot/kernel/kernel: FILESYSTEM > CLEAN; SKIPPING CHECKS > Dec 17 13:00:24 Master /boot/kernel/kernel: /dev/da1s1a: > Dec 17 13:00:24 Master /boot/kernel/kernel: clean, 42202 > free > Dec 17 13:00:24 Master /boot/kernel/kernel: (154 frags, > 5256 blocks, 0.2% fragmentation) > > and > > Dec 17 13:00:26 Master /boot/kernel/kernel: Doing > additional network setup: > Dec 17 13:00:26 Master /boot/kernel/kernel: ntpdate > Dec 17 13:00:26 Master /boot/kernel/kernel: ntpd > Dec 17 13:00:27 Master /boot/kernel/kernel: portmap > Dec 17 13:00:27 Master /boot/kernel/kernel: . > > Now, the first isn't a big deal, but the second is a little confusing. > Would there be any harm to changing the dots to something more > meaningful, like "Done with additional network setup" on its own line? I > seriously considered that when I was working on the echo's last night, > but I didn't want to be too revolutionary. :) The '.'s are simple and not too cluttery. Fixing the console to line buffer what it sends to log(9) is a better fix, IMO. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message