From owner-freebsd-current Sun Nov 17 14:25:09 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id OAA18314 for current-outgoing; Sun, 17 Nov 1996 14:25:09 -0800 (PST) Received: from rover.village.org (rover.village.org [204.144.255.49]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id OAA18300 for ; Sun, 17 Nov 1996 14:24:47 -0800 (PST) Received: from rover.village.org [127.0.0.1] by rover.village.org with esmtp (Exim 0.56 #1) id E0vPFdY-0002u3-00; Sun, 17 Nov 1996 15:24:24 -0700 To: Bruce Evans Subject: Re: UserConfig is broken + PS/2 support success Cc: current@freebsd.org In-reply-to: Your message of "Mon, 18 Nov 1996 02:03:37 +1100." <199611171503.CAA20387@godzilla.zeta.org.au> References: <199611171503.CAA20387@godzilla.zeta.org.au> Date: Sun, 17 Nov 1996 15:24:24 -0700 From: Warner Losh Message-Id: Sender: owner-current@freebsd.org X-Loop: FreeBSD.org Precedence: bulk In message <199611171503.CAA20387@godzilla.zeta.org.au> Bruce Evans writes: : >Bruce, if you spent as much time (re)coding, as you do analysing and : >describing others code, I think we all would be better off. This is : >NOT the way to encourage a new contributor. The code might not be : : I don't think so. Rewriting people's code is more likely to annoy : them than reviewing it. Personally speaking of course, I happen to like Bruce's review of any code that I check in. It has helped me learn things about the usual way around here in a very non-threatening sort of way. I generally don't like to get my code reviewed because most of my code reviews have been an "us vs them" experience, so I was pleasantly surprised that the checkins I made that he reviewed I reacted as well to the review as I did. It helped make the code better, and helped to make me more able to checking BSD-style code in the future. Anyway, that's just me and my world view. Others are welcome to disagree. Warner