From owner-freebsd-arch@FreeBSD.ORG Fri Feb 27 04:17:04 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2D6FAA9D; Fri, 27 Feb 2015 04:17:04 +0000 (UTC) Received: from mail.karels.net (mail.karels.net [63.231.190.5]) by mx1.freebsd.org (Postfix) with ESMTP id BBCB6BE7; Fri, 27 Feb 2015 04:17:03 +0000 (UTC) Received: from mail.karels.net (localhost [127.0.0.1]) by mail.karels.net (8.14.7/8.14.7) with ESMTP id t1R4H37Y058057; Thu, 26 Feb 2015 22:17:03 -0600 (CST) (envelope-from mike@karels.net) Message-Id: <201502270417.t1R4H37Y058057@mail.karels.net> To: Gleb Smirnoff From: Mike Karels Reply-to: mike@karels.net Subject: Re: Adding new media types to if_media.h In-reply-to: Your message of Fri, 27 Feb 2015 02:00:31 +0300. <20150226230031.GN17947@glebius.int.ru> Date: Thu, 26 Feb 2015 22:17:03 -0600 Cc: "freebsd-net@freebsd.org" , Eric Joyner , Jack Vogel , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Feb 2015 04:17:04 -0000 > M> I'm not sure what would be different about your approach; you mentioned "n" > M> versions rather than "x" versions of the ioctls, but I don't know what you > M> have in mind for encoding. Any compatible version would be limited to int. > The difference is that I suggest to go with a completely new interface. Yep, > as you say, if_media is basically wrong. So new ioctl will use new non-wrong > structure as argument. I think that part of the wrongness of if_media is to try to create a one-size-fits-all-network-types interface. If the replacement is a single ioctl, I don't think it's enough of an improvement to break the driver KPI. > And we achieve new feature in 10.2 by merging new ioctl back there, where > it will coexist with old unmodified interface. While in head, we no longer > need to carry forth the wrong if_media. I would think that this would be a huge problem for driver modules. And I think the old if_media will need to be supported for the user-level API for some time, unless someone is going to fix a lot of ports. Also, many of us are backporting much before 10.2. Mike