From owner-cvs-all@FreeBSD.ORG  Tue Dec  6 01:34:07 2011
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id C0FD1106566C;
	Tue,  6 Dec 2011 01:34:07 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org
	[IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id 5C38114EBC5;
	Tue,  6 Dec 2011 01:34:07 +0000 (UTC)
Message-ID: <4EDD710E.2040906@FreeBSD.org>
Date: Mon, 05 Dec 2011 17:34:06 -0800
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:8.0) Gecko/20111110 Thunderbird/8.0
MIME-Version: 1.0
To: Greg Larkin <glarkin@FreeBSD.org>
References: <201111232226.pANMQf10036293@repoman.freebsd.org>
In-Reply-To: <201111232226.pANMQf10036293@repoman.freebsd.org>
X-Enigmail-Version: undefined
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, Albert Gabas <agabas@astabis.com>,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/security/ossec-hids-server Makefile
 ports/security/ossec-hids-server/files
 ossec-hids.in patch-src__init__ossec-local.sh
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Dec 2011 01:34:07 -0000

1. The rc.d file needs a $FreeBSD$
2. Since it runs as an unprivileged user it should REQUIRE: LOGIN. Why
is it necessary to run earlier?
3. The ossechids_command() is not necessary. You could simply do (for
example): start_cmd="$command start"
4. Instead of touch/chown/chmod consider using install with the right
command line arguments in one go.


hth,

Doug


On 11/23/2011 14:26, Greg Larkin wrote:
> glarkin     2011-11-23 22:26:41 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     security/ossec-hids-server Makefile 
>     security/ossec-hids-server/files ossec-hids.in 
>   Added files:
>     security/ossec-hids-server/files 
>                                      patch-src__init__ossec-local.sh 
>   Log:
>   - Applied the startup script patch from PR ports/161524 to the local
>     installation type [1]
>   - Streamlined the rc.d file to use fewer functions
>   - Added a precmd to the rc.d file to ensure the proper ownership on
>     some queue files. OSSEC daemons don't properly chown them upon creation.
>   - Bumped PORTREVISION
>   
>   Reported by:    Albert Gabas <agabas@astabis.com> (via email) [1]
>   Feature safe:   yes
>   
>   Revision  Changes    Path
>   1.17      +4 -1      ports/security/ossec-hids-server/Makefile
>   1.4       +25 -15    ports/security/ossec-hids-server/files/ossec-hids.in
>   1.1       +11 -0     ports/security/ossec-hids-server/files/patch-src__init__ossec-local.sh (new)
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/ossec-hids-server/Makefile.diff?&r1=1.16&r2=1.17&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/ossec-hids-server/files/ossec-hids.in.diff?&r1=1.3&r2=1.4&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/ossec-hids-server/files/patch-src__init__ossec-local.sh
> 



-- 

		[^L]

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/