From owner-freebsd-bugs  Thu Dec 31 03:00:11 1998
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id DAA17506
          for freebsd-bugs-outgoing; Thu, 31 Dec 1998 03:00:11 -0800 (PST)
          (envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id DAA17497
          for <freebsd-bugs@FreeBSD.org>; Thu, 31 Dec 1998 03:00:10 -0800 (PST)
          (envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.8.8/8.8.5) id DAA14351;
	Thu, 31 Dec 1998 03:00:02 -0800 (PST)
Received: from ns11.rim.or.jp (ns11.rim.or.jp [202.247.130.230])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id CAA17305
          for <FreeBSD-gnats-submit@freebsd.org>; Thu, 31 Dec 1998 02:53:10 -0800 (PST)
          (envelope-from greg@greg.rim.or.jp)
Received: from rayearth.rim.or.jp (rayearth.rim.or.jp [202.247.130.242]) by ns11.rim.or.jp (8.8.5/3.5Wpl2-ns11/RIMNET-2) with ESMTP
	id TAA24681 for <FreeBSD-gnats-submit@freebsd.org>; Thu, 31 Dec 1998 19:52:48 +0900 (JST)
Received: (from uucp@localhost) by rayearth.rim.or.jp (8.8.8/3.5Wpl2-uucp1/RIMNET) with UUCP
	id TAA13222 for FreeBSD-gnats-submit@freebsd.org; Thu, 31 Dec 1998 19:52:47 +0900 (JST)
Received: from izanami.greg.rim.or.jp (izanami.greg.rim.or.jp [172.31.1.3])
	by apollon.greg.rim.or.jp (8.8.8/3.6W) with ESMTP id SAA12607;
	Thu, 31 Dec 1998 18:00:14 +0900 (JST)
Received: (from greg@localhost) by izanami.greg.rim.or.jp (8.8.8/3.4Wbeta6) id SAA06847; Thu, 31 Dec 1998 18:00:13 +0900 (JST)
Message-Id: <199812310900.SAA06847@izanami.greg.rim.or.jp>
Date: Thu, 31 Dec 1998 18:00:13 +0900 (JST)
From: greg@greg.rim.or.jp
Reply-To: greg@greg.rim.or.jp
To: FreeBSD-gnats-submit@FreeBSD.ORG
Cc: greg@greg.rim.or.jp
X-Send-Pr-Version: 3.2
Subject: bin/9252: enviroment value "KRBTKFILE" is not set by login
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         9252
>Category:       bin
>Synopsis:       login program "login" don't set KRBTKFILE collectory
>Confidential:   yes
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 31 03:00:01 PST 1998
>Last-Modified:
>Originator:     Kensaku Masuda
>Organization:
>Release:        FreeBSD 2.2.8-STABLE i386
>Environment:

	Enable KerberosIV enviroment

>Description:


	Program "login" call a function klogin(), And function returning a
string by krbtkfile_env. 

	char tkt_location[MAXPATHLEN];
	.
	.
	.
	if (strcmp(instance, "root") != 0)
		(void)sprintf(tkt_location, "%s%d", TKT_ROOT, pw->pw_uid);
	else {
		(void)sprintf(tkt_location, "%s_root_%d", TKT_ROOT, pw->pw_uid);
		krbtkfile_env = tkt_location;
	}

And krbtkfile_env is referenced outside of this function. So value is broken
at referencing time.
tkt_location must be static or allocated region on memory.

>How-To-Repeat:


>Fix:

--- klogin.c.orig	Thu Dec 31 17:40:48 1998
+++ klogin.c	Thu Dec 31 17:41:02 1998
@@ -68,7 +68,7 @@
 {
 	int kerror;
 	char realm[REALM_SZ], savehost[MAXHOSTNAMELEN];
-	char tkt_location[MAXPATHLEN];
+static	char tkt_location[MAXPATHLEN];
 	char *krb_get_phost();
 	extern int noticketsdontcomplain;
 
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message