From owner-cvs-all Thu Jun 18 07:52:36 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id HAA15933 for cvs-all-outgoing; Thu, 18 Jun 1998 07:52:36 -0700 (PDT) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.15.68.22]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id HAA15896; Thu, 18 Jun 1998 07:52:04 -0700 (PDT) (envelope-from bde@godzilla.zeta.org.au) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.8.7) id AAA00492; Fri, 19 Jun 1998 00:51:57 +1000 Date: Fri, 19 Jun 1998 00:51:57 +1000 From: Bruce Evans Message-Id: <199806181451.AAA00492@godzilla.zeta.org.au> To: bde@FreeBSD.ORG, dfr@nlsystems.com Subject: Re: cvs commit: src/sys/i386/i386 machdep.c src/sys/i386/include conf.h src/sys/i386/isa if_wl.c isa_device.h src/sys/i386/isa/sound ad1848.c src/sys/pci ide_pci.c src/sys/sys conf.h Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk >> Log: >> Don't declare isa device structs or isa interrupt handlers in , >> and don't depend on them being declared there. This will cause lots of >> warnings for a few minutes until config is updated. Interrupt handlers >> should never have been configured by config, and the machine generated >> declarations get in the way of changing the arg type from int to void *. >... >Does this mean that the individual drivers register their interrupt >handlers during attach? I haven't decided. It should be possible, and I currently call int isa_intr_establish(struct isa_device *idp, intrmask_t *maskp, inthand2_t *handler, void *arg); from the driver attach routines for the few drivers that I've converted, but a default of automatic registration on successful attach based on the contents of *idp has some advantages (such as not affecting pccard and pnp configuration immediately). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message