From owner-freebsd-ports-bugs@FreeBSD.ORG  Sun May 18 19:00:01 2014
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 631F7856
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Sun, 18 May 2014 19:00:01 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 50A342235
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Sun, 18 May 2014 19:00:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s4IJ0130057263
 for <freebsd-ports-bugs@freefall.freebsd.org>; Sun, 18 May 2014 19:00:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s4IJ00xa057262;
 Sun, 18 May 2014 19:00:00 GMT (envelope-from gnats)
Date: Sun, 18 May 2014 19:00:00 GMT
Message-Id: <201405181900.s4IJ00xa057262@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
Cc: 
From: John Marino <freebsd.contact@marino.st>
Subject: Re: ports/186610: Update port mail/assp to 14040 build
Reply-To: John Marino <freebsd.contact@marino.st>
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 18 May 2014 19:00:01 -0000

The following reply was made to PR ports/186610; it has been noted by GNATS.

From: John Marino <freebsd.contact@marino.st>
To: rnejdl@ringofsaturn.com, marino@freebsd.org
Cc: bug-followup@freebsd.org
Subject: Re: ports/186610: Update port mail/assp to 14040 build
Date: Sun, 18 May 2014 20:56:38 +0200

 On 5/18/2014 20:21, Rusty Nejdl wrote:
 > On 2014-05-13 01:31, John Marino wrote:
 > 
 >> Stumbling upon this ....
 >>
 >> Comments:
 >> 1) The fixes don't include stage support, which is mandatory now
 >> 2) The patch set includes several files that aren't actually changed:
 >> - files/510.assp.in
 >> - files/assp.in
 >> - files/patch-assp.pl
 >> - files/pkg-install.in
 >> 3) the assp.pl patch doesn't end in a new line (see patchset)
 >> 4) :U is used, that's got to be changed to :tu now
 >>
 >> In this case, the use of git hurt.  The patchset was blindly generated
 >> without noticing either the non-function svnid changes or the missing
 >> carriage return.
 >>
 >> I would fix these problems, then submit a new PR that has the words
 >> "support stage" in the title, with a new patch and then ask for the old
 >> PR to be closed.  I suggest this approach because ports that support
 >> stage will be noticed first.
 >>
 > Marino,
 > 
 > I'm working on this today since I have a quiet moment.  Any suggestions
 > on #3?
 > 
 
 #3 just means that the very last character of the file is not a carriage
 return.  Just go to the end, add a carriage return, and resave the file.
 
 John