From owner-freebsd-ports@FreeBSD.ORG  Wed Mar  9 17:05:48 2005
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0C5C216A4CE
	for <freebsd-ports@freebsd.org>; Wed,  9 Mar 2005 17:05:48 +0000 (GMT)
Received: from wproxy.gmail.com (wproxy.gmail.com [64.233.184.205])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7B19743D46
	for <freebsd-ports@freebsd.org>; Wed,  9 Mar 2005 17:05:47 +0000 (GMT)
	(envelope-from swhetzel@gmail.com)
Received: by wproxy.gmail.com with SMTP id 37so232412wra
        for <freebsd-ports@freebsd.org>; Wed, 09 Mar 2005 09:05:47 -0800 (PST)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
	s=beta; d=gmail.com;
	h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references;
	b=HcmJwPi3jEsEoCicYYp9rVJ4WzVVGHUYGGRBl0aiRMtrKZyO4n/qnXT/ZjzP8NQfyasQVXjTuyppbSYgrsVkrjKhNF03RBtRcsXkQI2GE9GD9YUuWIhLLjAetl6fQ7KKQgpgILfpm55pIaKzsmOUVyM6V49Nf0+uDrP/Jka0QUM=
Received: by 10.54.4.8 with SMTP id 8mr962871wrd;
        Wed, 09 Mar 2005 09:05:46 -0800 (PST)
Received: by 10.54.29.77 with HTTP; Wed, 9 Mar 2005 09:05:46 -0800 (PST)
Message-ID: <790a9fff05030909051a681126@mail.gmail.com>
Date: Wed, 9 Mar 2005 11:05:46 -0600
From: Scot Hetzel <swhetzel@gmail.com>
To: Francois Tigeot <ftigeot@wolfpond.org>
In-Reply-To: <790a9fff05030909047e24089c@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
References: <20050308085234.GA22654@aoi.wolfpond.org>
	 <790a9fff05030909047e24089c@mail.gmail.com>
cc: freebsd-ports@freebsd.org
Subject: Re: x11/xlockmore disables MESAGL on amd64
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Scot Hetzel <swhetzel@gmail.com>
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Mar 2005 17:05:48 -0000

On Wed, 9 Mar 2005 11:04:26 -0600, Scot Hetzel <swhetzel@gmail.com> wrote:
> On Tue, 8 Mar 2005 09:52:34 +0100, Francois Tigeot <ftigeot@wolfpond.org> wrote:
> > GL modes have been disabled on amd64 more than a year ago. According to the
> > commit message, it was done to fix build problems.
> >
> > I re-enabled them locally; xlockmore built without trouble and all GL modes
> > work fine on a 5.4-PRERELEASE/amd64 host.
> >
> > Should I submit a PR or is the attached patch sufficient ?
> >
> I looked at the patch and it removes the check for amd64.  The check
> should have been changed to include OSVERSION, as the GL modes are
> broken on older versions.
> 
> .if ${MACHINE_ARCH} == "amd64"  && ${OSVERSION} < 503105
> WITH_MESAGL=    no
> .else
> WITH_MESAGL?=  yes
> .endif
> 
> Also, if you can test on a 5.3-RELEASE system, you could bring the
> OSVERSION down even further.
> 
PS. You should always send it as a PR.

Scot