From owner-freebsd-net  Fri Oct 27  7:31:58 2000
Delivered-To: freebsd-net@freebsd.org
Received: from darren2.lnk.telstra.net (darren2.lnk.telstra.net [139.130.53.33])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5847237B479; Fri, 27 Oct 2000 07:31:49 -0700 (PDT)
Received: (from root@localhost)
	by darren2.lnk.telstra.net (8.11.0/8.11.0) id e9REVkE28948;
	Sat, 28 Oct 2000 01:31:46 +1100 (EST)
From: Darren Reed <darrenr@reed.wattle.id.au>
Message-Id: <200010271431.BAA19966@avalon.reed.wattle.id.au>
Subject: Re: [CFR] IPFILTER patch
In-Reply-To: <20001027170933.A36523@sunbay.com> from Ruslan Ermilov at "Oct 27, 0 05:09:33 pm"
To: ru@FreeBSD.org (Ruslan Ermilov)
Date: Sat, 28 Oct 2000 01:31:23 +1100 (EST)
Cc: net@FreeBSD.org
X-Mailer: ELM [version 2.4ME+ PL37 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

In some email I received from Ruslan Ermilov, sie wrote:
> Hi!
> 
> As we discussed yesterday, here are the patches to IPFILTER
> that are needed for my upcoming "byte-swapping elimination"
> patch.  Sorry, it took a bit more than an hour...

Hmm, there are some problems with this.

In some cases, off is being put into an int (should always be
a u_short) but of more concern is that you're treating fin_off
as both a byte address (you shift it left three times) and as
the eight byte offset it actually is in the packet.

Cheers,
Darren


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message