From owner-freebsd-emulation@FreeBSD.ORG  Thu Nov 30 18:15:23 2006
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
X-Original-To: freebsd-emulation@FreeBSD.org
Delivered-To: freebsd-emulation@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 0AEEB16A415;
	Thu, 30 Nov 2006 18:15:23 +0000 (UTC)
	(envelope-from jhein@timing.com)
Received: from Daffy.timing.com (w.timing.com [206.168.13.218])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5897543CA6;
	Thu, 30 Nov 2006 18:15:13 +0000 (GMT)
	(envelope-from jhein@timing.com)
Received: from gromit.timing.com (gromit.timing.com [206.168.13.209])
	by Daffy.timing.com (8.13.1/8.13.1) with ESMTP id kAUIFLmN054159;
	Thu, 30 Nov 2006 11:15:21 -0700 (MST)
	(envelope-from jhein@timing.com)
Received: from gromit.timing.com (localhost [127.0.0.1])
	by gromit.timing.com (8.13.8/8.13.8) with ESMTP id kAUIFIbn039755;
	Thu, 30 Nov 2006 11:15:18 -0700 (MST)
	(envelope-from jhein@gromit.timing.com)
Received: (from jhein@localhost)
	by gromit.timing.com (8.13.8/8.13.8/Submit) id kAUIFHdQ039752;
	Thu, 30 Nov 2006 11:15:17 -0700 (MST) (envelope-from jhein)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <17775.8117.809750.563506@gromit.timing.com>
Date: Thu, 30 Nov 2006 11:15:17 -0700
From: John E Hein <jhein@timing.com>
To: Jung-uk Kim <jkim@FreeBSD.org>
In-Reply-To: <200611291616.33903.jkim@FreeBSD.org>
References: <20061106174033.GA70360@stud.fit.vutbr.cz>
	<200611071201.11899.jkim@FreeBSD.org>
	<17773.62597.411535.477324@gromit.timing.com>
	<200611291616.33903.jkim@FreeBSD.org>
X-Mailer: VM 7.19 under Emacs 22.0.50.1
X-Virus-Scanned: ClamAV version 0.87.1,
	clamav-milter version 0.87 on Daffy.timing.com
X-Virus-Status: Clean
Cc: freebsd-emulation@FreeBSD.org
Subject: Re: [PATCH]: possible fix for the fifoor problem
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Development of Emulators of other operating systems
	<freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Nov 2006 18:15:23 -0000

Jung-uk Kim wrote at 16:16 -0500 on Nov 29, 2006:
 > This is fixed differently in P4:
 > 
 > http://perforce.freebsd.org/changeView.cgi?CH=109652
 > 
 > You can download the latest linux_stats.c directly from P4 web page:
 > 
 > http://perforce.freebsd.org/fileDownLoad.cgi?FSPC=//depot/projects/linuxolator/src/sys/compat/linux/linux%5fstats.c&REV=5
 > 

Thanks.

This patch (a small, but important, subset of your REV 5 above) was
good enough for me on 6.x - it seems to solve the problems I've been
seeing with linux_seamonkey dialog boxes...

Index: src/sys/compat/linux/linux_stats.c
===================================================================
RCS file: /base/FreeBSD-CVS/src/sys/compat/linux/linux_stats.c,v
retrieving revision 1.72.2.3
diff -u -p -r1.72.2.3 linux_stats.c
--- src/sys/compat/linux/linux_stats.c	15 Jun 2006 19:08:03 -0000	1.72.2.3
+++ src/sys/compat/linux/linux_stats.c	29 Nov 2006 21:35:48 -0000
@@ -128,6 +128,8 @@ translate_path_major_minor(struct thread
 	int fd;
 	int temp;
 
+	if (!S_ISCHR(buf->st_mode) && !S_ISBLK(buf->st_mode))
+		return;
 	temp = td->td_retval[0];
 	if (kern_open(td, path, UIO_SYSSPACE, O_RDONLY, 0) != 0)
 		return;