From owner-cvs-src@FreeBSD.ORG Wed Aug 24 20:56:59 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0D9F616A41F; Wed, 24 Aug 2005 20:56:59 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6635243D45; Wed, 24 Aug 2005 20:56:58 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 73D5852C3F; Wed, 24 Aug 2005 22:56:56 +0200 (CEST) Received: from localhost (djy66.neoplus.adsl.tpnet.pl [83.24.2.66]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 6F4E252BC4; Wed, 24 Aug 2005 22:56:48 +0200 (CEST) Date: Wed, 24 Aug 2005 22:56:27 +0200 From: Pawel Jakub Dawidek To: John Baldwin Message-ID: <20050824205627.GD755@garage.freebsd.pl> References: <200508241938.j7OJcSNW066686@repoman.freebsd.org> <200508241602.59424.jhb@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Xm/fll+QQv+hsKip" Content-Disposition: inline In-Reply-To: <200508241602.59424.jhb@FreeBSD.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng devel (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,RCVD_IN_NJABL_DUL, RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/pkill pkill.1 pkill.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Aug 2005 20:56:59 -0000 --Xm/fll+QQv+hsKip Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 24, 2005 at 04:02:57PM -0400, John Baldwin wrote: +> On Wednesday 24 August 2005 03:38 pm, Pawel Jakub Dawidek wrote: +> > pjd 2005-08-24 19:38:28 UTC +> > +> > FreeBSD src repository +> > +> > Modified files: +> > usr.bin/pkill pkill.1 pkill.c +> > Log: +> > Modify '-F' option to work nicely with pidfile(3) - a pidfile given = as +> > an argument has to be locked. +> > +> > Revision Changes Path +> > 1.17 +8 -0 src/usr.bin/pkill/pkill.1 +> > 1.27 +14 -0 src/usr.bin/pkill/pkill.c +>=20 +> I guess the only thing that makes me uncomfortable about this change is = that=20 +> it means pkill won't work with 3rd party program's pid files since they = are=20 +> probably not using pidfile(3). Maybe have some way of turning off the f= lock=20 +> requirement? Some daemons, even if they don't use pidfile(3), they do use flock(2) to lo= ck the pidfile (eg. cron(8)). I added this option to pkill(1) in the past, but I wasn't very happy with it until today... On the other hand, I added it to avoid: kill `cat /var/run/daemon.pid`... Hmm, what do you think about reverting '-F' behaviour and make it use flock(2) only when '-L' is also given? --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --Xm/fll+QQv+hsKip Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDDN77ForvXbEpPzQRAtCyAKCdQHYTPvQyIOvcq5aUCdNw3dw80gCfSRZf l6414wNVk9ZIZJm5hr26h8w= =xvNY -----END PGP SIGNATURE----- --Xm/fll+QQv+hsKip--