From owner-svn-ports-head@FreeBSD.ORG Fri May 24 17:14:41 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 817BC1D7 for ; Fri, 24 May 2013 17:14:41 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-pb0-x22d.google.com (mail-pb0-x22d.google.com [IPv6:2607:f8b0:400e:c01::22d]) by mx1.freebsd.org (Postfix) with ESMTP id 5B43F108 for ; Fri, 24 May 2013 17:14:41 +0000 (UTC) Received: by mail-pb0-f45.google.com with SMTP id mc17so4466131pbc.32 for ; Fri, 24 May 2013 10:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=neUSzW2cKoh1RPmUhHfRmxExFOTESRc6N2AFn4f6yag=; b=jviuZoSFS5OKFB67tA2mX0xGWdq1UKgyc1atBkZ5YJN2QCeJvIQpOwa+mdrZ0QLC4E O4wZSjma8o207MxTnqGt3t2Ice5LhpB94Qs6IJN6suo2kGRPKtQ1iSRDdpCqRGcEqZjk OvYmwSv005e+2q5l34+PE6KVH7Tmahfsz2SOc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=neUSzW2cKoh1RPmUhHfRmxExFOTESRc6N2AFn4f6yag=; b=FZ+/Dkhp5BwlANM4tW3rK77mkqRCcvkxf4aZGKnR6jeRqIA6EnI1Gv4oC0WDcQ8L9y dUvY03zJQiElox9Pes45kCLD/W/Jii0zfiBhGxI99Q/iLT04J16sb11VFaKdyoYjxkVD 8060mnhe/YvhpCwV0r91jWMfDg8o8GPiolZohlgVSoLau9Hg777+MNP3QUYcw/8Tx/lW Jpz3JHzICzqFg/mKg3p4jTTSimQ1WFXMFkYgVp/VQUnm9hyxWHkLSEAttaLgjbxefeVH 7w1vqPui5v7q9Sj0E6kyEJNRn/IfiDahj+nRFj566NolwEf4QSiijxlZwm1c1QQIioZY Z8hg== X-Received: by 10.66.118.39 with SMTP id kj7mr14007416pab.90.1369415681136; Fri, 24 May 2013 10:14:41 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.70.84.100 with HTTP; Fri, 24 May 2013 10:14:09 -0700 (PDT) In-Reply-To: <20130524033728.GE48975@FreeBSD.org> References: <201305232205.r4NM5MSa002349@svn.freebsd.org> <20130524033728.GE48975@FreeBSD.org> From: Eitan Adler Date: Fri, 24 May 2013 19:14:09 +0200 X-Google-Sender-Auth: sPoa_nPDZcIL5Nul5m7qmYFDAOw Message-ID: Subject: Re: svn commit: r318913 - in head/devel/libcfu: . files To: Alexey Dokuchaev Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQlCWpn50AYndIRFFn6DL8WztLAf/3HOWjqOdgQEmQAOffFR9t+ygT8/f8N8+HyB2bQijt+x Cc: Chris Rees , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 May 2013 17:14:41 -0000 On 24 May 2013 05:37, Alexey Dokuchaev wrote: > On Thu, May 23, 2013 at 10:05:22PM +0000, Chris Rees wrote: >> New Revision: 318913 >> URL: http://svnweb.freebsd.org/changeset/ports/318913 >> >> Log: >> New versions of clang complain about assigning variables to themselves. >> >> Let's just remove -Werror and ignore the warnings. > > Hmm, wouldn't it be better to fix these bugs (judging from commit log it > should not be too hard) and send the patch upstream? I agree fixing these bugs is a good thing. I don't believe that this is a function of the ports team though. IMHO disabling warnings is the simplest, least intrusive patch that works. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams