From owner-cvs-all@FreeBSD.ORG  Sun Feb 12 23:21:43 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8ACAB16A426
	for <cvs-all@FreeBSD.org>; Sun, 12 Feb 2006 23:21:43 +0000 (GMT)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4])
	by mx1.FreeBSD.org (Postfix) with SMTP id 9983A43D49
	for <cvs-all@FreeBSD.org>; Sun, 12 Feb 2006 23:21:41 +0000 (GMT)
	(envelope-from dougb@FreeBSD.org)
Received: (qmail 8737 invoked by uid 399); 12 Feb 2006 23:21:40 -0000
Received: from localhost (HELO ?192.168.1.100?) (dougb@dougbarton.us@127.0.0.1)
	by localhost with SMTP; 12 Feb 2006 23:21:40 -0000
Message-ID: <43EFC302.40001@FreeBSD.org>
Date: Sun, 12 Feb 2006 15:21:38 -0800
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Thunderbird 1.5 (X11/20060112)
MIME-Version: 1.0
To: Matteo Riondato <matteo@FreeBSD.org>
References: <200602121004.k1CA4vJG056410@repoman.freebsd.org>
In-Reply-To: <200602121004.k1CA4vJG056410@repoman.freebsd.org>
X-Enigmail-Version: 0.94.0.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: src-committers@FreeBSD.org, freebsd-rc@freebsd.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org, philip@freebsd.org, Craig Carey <research@ijs.co.nz>
Subject: Re: cvs commit: src/etc/rc.d localpkg
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: freebsd-rc@freebsd.org
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Feb 2006 23:21:43 -0000

Matteo Riondato wrote:
> matteo      2006-02-12 10:04:56 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     etc/rc.d             localpkg 
>   Log:
>   Make localpkg print local scripts names when the boot is verbose
>   
>   PR:             conf/68525  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=68525
>   Approved by:    philip (mentor)
>   MFC after:      3 days
>   
>   Revision  Changes    Path
>   1.8       +3 -0      src/etc/rc.d/localpkg
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/src/etc/rc.d/localpkg.diff?&r1=1.7&r2=1.8&f=h

Please hold off on the MFC of this patch till we have a chance to discuss it
more. I'm not opposed to the concept of printing out script names as they
are executed, but that should be done using one of the existing rc.subr
mechanisms (probably debug, as that's how it's done in rc.subr for new style
scripts).

I'm not asking you to back this out, but I would appreciate it if you'd
reply to the -rc list so that we can discuss it further before we move forward.

Thanks,

Doug

-- 

    This .signature sanitized for your protection