From owner-freebsd-standards@FreeBSD.ORG Fri Sep 2 12:59:58 2011 Return-Path: Delivered-To: freebsd-standards@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BD779106564A; Fri, 2 Sep 2011 12:59:58 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 9DA208FC19; Fri, 2 Sep 2011 12:59:57 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id PAA19362; Fri, 02 Sep 2011 15:59:55 +0300 (EEST) (envelope-from avg@FreeBSD.org) Message-ID: <4E60D34B.6050506@FreeBSD.org> Date: Fri, 02 Sep 2011 15:59:55 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:5.0) Gecko/20110705 Thunderbird/5.0 MIME-Version: 1.0 To: Andrey Chernov , Jilles Tjoelker , freebsd-net@FreeBSD.org, freebsd-standards@FreeBSD.org References: <4E60A1B8.7080607@FreeBSD.org> <20110902104018.GA12845@stack.nl> <4E60B842.8050506@FreeBSD.org> <20110902112116.GA23835@vniz.net> In-Reply-To: <20110902112116.GA23835@vniz.net> X-Enigmail-Version: 1.2pre Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: Subject: Re: POLLHUP on never connected socket X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Sep 2011 12:59:58 -0000 on 02/09/2011 14:21 Andrey Chernov said the following: > On Fri, Sep 02, 2011 at 02:04:34PM +0300, Andriy Gapon wrote: >> on 02/09/2011 13:40 Jilles Tjoelker said the following: >>> Ports people have complained about poll() behaviour before, are there >>> configure scripts that attempt to check if we ever return POLLHUP alone >>> and only check for POLLIN if not? >> >> Not sure about that other software and how POLLIN is related here. >> The software in question (mozilla nspr) checks for POLLNVAL, POLLERR, POLLPRI >> and POLLOUT to determine if anything interesting has happened to a connection >> supposed to be in progress. They aren't checking for POLLHUP at all and thus >> they keep thinking that the connection is still in progress when they get it. > > It seems for such case it should return POLLERR too. > I think that I would agree as this is not a graceful disconnect / hang-up but an error in trying to connect. Anyway I am not an expert in this matters and I'd think that POLLHUP should be checked anyway - better safe than sorry. -- Andriy Gapon