From owner-freebsd-scsi@FreeBSD.ORG  Tue Jul 23 07:11:33 2013
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
Delivered-To: scsi@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id B06A4DA3;
 Tue, 23 Jul 2013 07:11:33 +0000 (UTC) (envelope-from uqs@FreeBSD.org)
Received: from acme.spoerlein.net (acme.spoerlein.net
 [IPv6:2a01:4f8:131:23c2::1])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4DA202B27;
 Tue, 23 Jul 2013 07:11:33 +0000 (UTC)
Received: from localhost (acme.spoerlein.net [IPv6:2a01:4f8:131:23c2::1])
 by acme.spoerlein.net (8.14.7/8.14.7) with ESMTP id r6N7BU2e099728
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Tue, 23 Jul 2013 09:11:31 +0200 (CEST)
 (envelope-from uqs@FreeBSD.org)
Date: Tue, 23 Jul 2013 09:11:30 +0200
From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@FreeBSD.org>
To: scsi@freebsd.org
Subject: Re: Please review patch for aic7xxx_pci.c
Message-ID: <20130723071129.GD9030@acme.spoerlein.net>
References: <20130716094927.GA9030@acme.spoerlein.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20130716094927.GA9030@acme.spoerlein.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: gibbs@FreeBSD.org, ken@freebsd.org
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-scsi>,
 <mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
 <mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Jul 2013 07:11:33 -0000

[adding scsi, it would be nice if I could get another set of eyes on
this as I don't have the hardware to test this]

On Tue, 2013-07-16 at 11:49:27 +0200, Ulrich Spörlein wrote:
> 
> Hey Justin, Ken,
> 
> Coverity found one more instance of swapped parameters in the kernel,
> introduced quite some time ago. It's probably hard to get the hardware
> to test this change these days ...
> 
> Please see
> https://github.com/uqs/freebsd-head/commit/2f8f438a380c2a52a2e9f266cd716f56c8a4bb75
> and leave comments, or reply to this mail.
> 
> You can see the diff that introduced the problem here:
> http://git.freebsd.your.org/gitweb/?p=freebsd.git;a=blobdiff;f=sys/dev/aic7xxx/aic7xxx_pci.c;h=42dcdcc57f09d11199aabd6b224f2dad730f0733;hp=a4c0f4672cab3eb965d7acf1a580162168ca9716;hb=27ca4db2579f6e74861db16299eeb52e158fa7a7;hpb=06842004edacee7beec6cb72239ded59709506a2
> 
> or here:
> 
> https://github.com/uqs/freebsd-head/commit/9696016b0572574bb656fb109ff2916127fa8cb8
> 
> Thanks!
> Uli